Skip to content
This repository has been archived by the owner on Jun 12, 2024. It is now read-only.

Added instructions for Google Container Registry #116

Closed
wants to merge 1 commit into from
Closed

Added instructions for Google Container Registry #116

wants to merge 1 commit into from

Conversation

DazWilkin
Copy link

These changes are known to work with Google Container Registry.

The existing instructions were insufficient.

Reference here:
https://cloud.google.com/container-registry/docs/advanced-authentication#using_an_access_token

I blogged about running Draft on Google Container Engine:
https://medium.com/@DazWilkin/azure-draft-on-google-container-engine-d1b25530a313

These changes are known to work with Google Container Registry.

The existing instructions were insufficient.

Reference here:
https://cloud.google.com/container-registry/docs/advanced-authentication#using_an_access_token

I blogged about running Draft on Google Container Engine:
https://medium.com/@DazWilkin/azure-draft-on-google-container-engine-d1b25530a313
@msftclas
Copy link

msftclas commented Jun 6, 2017

@DazWilkin,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.

It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot


```
$ echo '{"registrytoken":"9cbaf023786cd7"}' | base64
```

### For Google Container Registry:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind making the other topics like token-based auth a header as well for consistency?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, I'm not going to be able to accept the CLA.

Unless I hear otherwise, I'll revert this tomorrow morning.

Apologies for the inconvenience.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh no that's a shame!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:'(


```
$ ACCESS_TOKEN=$(gcloud auth application-default print-access-token)
$ AUTH_TOKEN=$(echo "{\"username\":\"_token\",\"password\":\"$ACCESS_TOKEN\"}" | base64 --wrap=0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might want to make this -w 0 instead, as both GNU and darwin base64 both understand the short form.

@bacongobbler
Copy link
Contributor

closing in favour of #154 as this documentation will all be going away with the draft init rewrite.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants