Properly Version Build Dependencies for Azlinux #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamperlin
changed the title
adamperlin
changed the title
cpuguy83
requested changes
Jul 29, 2024
…ion-build-dependencies
adamperlin
force-pushed
the
adamperlin/version-build-dependencies
branch
from
18c27be
to
d893268
Compare
cpuguy83
reviewed
Aug 6, 2024
cpuguy83
approved these changes
Aug 6, 2024
|
Github says there is a conflict. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes #309 for azlinux targets. Currently, if version constraints are specified for build dependencies in the Dalec spec the dependencies are completely ignored when actually installing the packages with
tdnf. However, the constraints are still emitted asBuildRequiresin the generated RPM spec for the main package. This means that currently, we could run into cases where the versions of build dependencies installed by Dalec in the worker container would be incompatible with a user's constraints, causing rpmbuild to fail with no way for a user to acceptably resolve the issue without removing their build version constraints.How it works
A build dependency for a Dalec package is essentially just a runtime package dependency for the worker container. Thus, we can simply create a meta-package (for azlinux, azlinux-build-dependencies), which has as its runtime dependencies the build dependencies specified in the dalec spec. We then install our build dependency package in the worker container and let the package manager handle the version constraints for us.
This bug has not yet been fixed for windows as those targets use a jammy worker container and thus will likely require building a
.debfor build dependencies, functionality for which is pending with jammy support.