Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Constraints for build dependencies are ignored in the build env #309

Closed
1 task
cpuguy83 opened this issue Jul 3, 2024 · 0 comments · Fixed by #337
Closed
1 task

[BUG] Constraints for build dependencies are ignored in the build env #309

cpuguy83 opened this issue Jul 3, 2024 · 0 comments · Fixed by #337
Assignees
Labels
bug Something isn't working
Milestone

Comments

@cpuguy83
Copy link
Member

cpuguy83 commented Jul 3, 2024

Expected Behavior

When a dalec spec contains version requirements for a dependency 👍

dependencies:
  build:
    foo: [">= 1.0", "<2.0"]

The mariner2 and azlinux3 should respect those dependencies when setting up the build environment.

Actual Behavior

The rpm spec is correct in that includes those dependency constraints, however the actual build environment does not.
I believe rpmbuild will error out if the versions are not within those constraints, but currently we just tdnf install <dep1> <dep2> ... which can land us in a situation where the build cannot succeed with version constraints in it.

Steps To Reproduce

N/A

Are you willing to submit PRs to contribute to this bug fix?

  • Yes, I am willing to implement it.
@cpuguy83 cpuguy83 added the bug Something isn't working label Jul 3, 2024
@cpuguy83 cpuguy83 added this to the vNext milestone Jul 3, 2024
@cpuguy83 cpuguy83 assigned adamperlin and unassigned jeremyrickard Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants