Add new spec for URI template #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timotheeguerin
requested review from
iscai-msft,
lmazuel,
m-nash,
joheredi,
srnagar,
weidongxu-microsoft and
tadelesh
as code owners
🦋 Changeset detectedLatest commit: f178d6f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
timotheeguerin
commented
Aug 8, 2024
timotheeguerin
commented
Aug 8, 2024
There was a problem hiding this comment.
LGTM except one question at #673 (comment)
I didn't check the detailed mockapi impl. I guess the first dev impl these tests in emitter would make the runtime check.
tadelesh
reviewed
Aug 13, 2024
2 tasks
MaryGao
reviewed
Aug 19, 2024
iscai-msft
reviewed
Aug 19, 2024
iscai-msft
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cadl Ranch Contribution Checklist:
@scenarionames. Someone can look at the list of scenarios and understand what I'm covering.@scenarioDocs for extra scenario description and to tell people how to pass my mock api check.There is a lot of new scenario covering all the cases. The goal is not necessarily that all emitter should support all the cases immediately but this will then help keeping track of uri template support across emitter
resolve: #666
resolve: #665