Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Force partition key parameter and Fix hierarchical partition key deployment and analytical store enablement #1223

Merged
merged 21 commits into from
Mar 13, 2024
Merged

fix: Force partition key parameter and Fix hierarchical partition key deployment and analytical store enablement #1223

merged 21 commits into from
Mar 13, 2024

Conversation

bryansan-msft
Copy link
Contributor

@bryansan-msft bryansan-msft commented Mar 9, 2024

Description

Closes Azure/ResourceModules#4278

Remarks

  • I have had to hardcode the region where the tests are being deployed to eastus as the pipeline is picking up a random region which might have new cosmosdb constraints or not supported features that the tests need. In my opinion is better to hardcode the region rather than remove the tests. I didn't find a way to tell the pipeline to deploy to specific regions without affecting all pipelines.

Pipeline Reference

Pipeline
avm.res.document-db.database-account

Type of Change

  • Update to CI Environment or utlities (Non-module effecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

Added more tests convering most configurations.
Make partition key mandatory.
Added user defined types for better consumer experience.
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Mar 9, 2024
Added flag to enable synapse analytics link.
Fixed unnecesary database throughput when the user doesnt specify it but it does at container level.
Fixed unnecesary container throughput when the user doesnt specify it but it does at database level.
Added more tests related to throughput
@bryansan-msft bryansan-msft changed the title Added default values to description. fix: Added default values to description. Mar 9, 2024
@bryansan-msft bryansan-msft requested a review from krbar March 9, 2024 18:22
@bryansan-msft bryansan-msft self-assigned this Mar 9, 2024
@bryansan-msft
Copy link
Contributor Author

bryansan-msft commented Mar 13, 2024

@AlexanderSehr Readme problem is already solved, changes are already implemented and new pipeline run is green.

@bryansan-msft bryansan-msft merged commit f2ad8df into Azure:main Mar 13, 2024
9 checks passed
@bryansan-msft bryansan-msft deleted the fix/bryansan-msft/4278/force-partition-key branch March 25, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment