[AVM Module Issue]: PartitionKey should be required by the container resource for a NoSQL database #1222
Closed
1 task done
Assignees
Labels
Class: Resource Module 📦
This is a resource module
Type: AVM 🅰️ ✌️ Ⓜ️
This is an AVM related issue
Type: Bug 🐛
Something isn't working
Comments
bryansan-msft
added
Needs: Triage 🔍
microsoft-github-policy-service
bot
added
Needs: Attention 👋
|
@bryansan-msft, thanks for submitting this issue for the A member of the @azure/avm-res-documentdb-databaseaccount-module-owners-bicep or @azure/avm-res-documentdb-databaseaccount-module-contributors-bicep team will review it soon! |
11 tasks
11 tasks
matebarabas
removed
Needs: Triage 🔍
bryansan-msft
added a commit
that referenced
this issue
Mar 13, 2024
… deployment and analytical store enablement (#1223) ## Description - Added more tests covering most NoSQL API and Account focused configurations. - Removed non-related NoSQL API tests from its test suite (They were already covered by waf-aligned and plain test suite). - Make partition key path parameter mandatory. - Fixes #1222 - Add "/" to partition key path if the user doesn't specify it to avoid errors when it's missing - Added user defined types for better consumer experience and intelisense. - Closes #1227 - Fixed an issue where deployment of a hierarchical partition key would fail even though it was allowed through parameter. - Fixes #1229 - Fixed an issue where you were forced to have RUs both in Container and Database due to default values being used. It was impossible to have RUs only at one level - Fixes #1226 - Fixed an issue where analytical store ttl couldn't be enabled since there was missing a parameter (enableAnalyticalStore) at account level - Fixes #1225 - Allow disabling local auth for NoSQL API as it is the recommended configuration when using managed identity's - Closes #1228 ## Remarks - I have had to hardcode the region where the tests are being deployed to eastus as the pipeline is picking up a random region which might have new cosmosdb constraints or not supported features that the tests need. <!-- >Thank you for your contribution ! > Please include a summary of the change and which issue is fixed. > Please also include the context. > List any dependencies that are required for this change. Fixes #123 Fixes #456 Closes #123 Closes #456 --> ## Pipeline Reference <!-- Insert your Pipeline Status Badge below --> | Pipeline | | -------- | | [](https://github.com/bryansan-msft/fork-bicep-registry-modules/actions/workflows/avm.res.document-db.database-account.yml) | ## Type of Change <!-- Use the check-boxes [x] on the options that are relevant. --> - [ ] Update to CI Environment or utlities (Non-module effecting changes) - [ ] Azure Verified Module updates: - [x] Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`: - [x] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description. - [x] The bug was found by the module author, and no one has opened an issue to report it yet. - [x] Feature update backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] Breaking changes and I have bumped the MAJOR version in `version.json`. - [x] Update to documentation ## Checklist - [x] I'm sure there are no other open Pull Requests for the same update/change - [x] I have run `Set-AVMModule` locally to generate the supporting module files. - [x] My corresponding pipelines / checks run clean and green without any errors or warnings <!-- Please keep up to day with the contribution guide at https://aka.ms/avm/contribute/bicep -->
](https://github.com/bryansan-msft/fork-bicep-registry-modules/actions/workflows/avm.res.document-db.database-account.yml){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Check for previous/existing GitHub issues
Issue Type?
Bug
Module Name
avm/res/document-db/database-account
(Optional) Module Name if not listed above
No response
(Optional) Module Version
No response
Description
This was reported in the CARML repository and hasn't been solved so far. This module inherited this bug as part of the porting
Azure/ResourceModules#4278
(Optional) Correlation Id
No response
The text was updated successfully, but these errors were encountered: