Update submodules#2378
Merged
Merged
Conversation
Password is now correctly flagged with x-ms-secret and there are flow on effects, including type name and local variable changes. Technically removing Password from ImageRegistryCredential_Status is breaking, but it would have always been empty anyway.
New optional properties DataEncryption and Identity added to FlexibleServer.
Breaking: Identity removed from cdn.Profile; according to PR#18187 it's not ready for GA and will return in a later preview API version.
Rename of `ETag` to `Etag` and documentation to match.
We now find nothing when scanning the JSON schema; deferring further investigation until we're swagger only for our source data.
theunrepentantgeek
requested review from
Porges,
babbageclunk,
davefellows,
matthchr and
super-harsh
as code owners
Member
I think really (in the serialized payload) it's a rename from |
matthchr
reviewed
Jul 8, 2022
| // Deprecated version of Identity. Use v1beta20210501.Identity instead | ||
| type Identity struct { | ||
| Type *IdentityType `json:"type,omitempty"` | ||
| UserAssignedIdentities map[string]v1.JSON `json:"userAssignedIdentities,omitempty"` |
Member
There was a problem hiding this comment.
I think this is readonyl and should be removed in our config.
super-harsh
approved these changes
Jul 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Updates our upstream submodules to a more recent version and modifies our configuration to match.
cdn
Breaking: Identity removed from cdn.Profile; according to PR#18187 it's not ready for GA and will return in a later preview API version.
containerinstance
Password is now correctly flagged with x-ms-secret and there are flow on effects, including type names and local variable changes.
costmanagement
We now find nothing when scanning the JSON schema; deferring further investigation until we're swagger only for our source data.
dbformysql
New optional properties DataEncryption and Identity added to FlexibleServer.
operationalinsights
Rename of property
eTagtoetagand documentation to match.How does this PR make you feel:
If applicable: