Skip to content

[CDN][2021-06-01] Remove unsupported properties for Azure Front Door Standard/Premium GA#18187

Merged
chunyu3 merged 2 commits into
Azure:mainfrom
t-bzhan:afdx_ga_march
Mar 16, 2022
Merged

[CDN][2021-06-01] Remove unsupported properties for Azure Front Door Standard/Premium GA#18187
chunyu3 merged 2 commits into
Azure:mainfrom
t-bzhan:afdx_ga_march

Conversation

@t-bzhan
Copy link
Copy Markdown
Contributor

@t-bzhan t-bzhan commented Mar 11, 2022

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify: The api version 2021-06-01 is not actually used in production yet, this PR aims to remove the unsupported properties for our new service GA.
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@t-bzhan t-bzhan requested a review from ravindp March 11, 2022 13:21
@t-bzhan t-bzhan requested a review from jorinmejia as a code owner March 11, 2022 13:21
@openapi-workflow-bot
Copy link
Copy Markdown

Hi, @t-bzhan Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-workflow-bot
    Copy link
    Copy Markdown

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link
    Copy Markdown

    openapi-pipeline-app Bot commented Mar 11, 2022

    Swagger Validation Report

    ️❌BreakingChange: 7 Errors, 0 Warnings failed [Detail]
    Rule Message
    1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ManagedServiceIdentity' removed or renamed?
    New: Microsoft.Cdn/stable/2021-06-01/afdx.json#L3954:3
    Old: Microsoft.Cdn/stable/2021-06-01/afdx.json#L3954:3
    1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.Cdn/stable/2021-06-01/afdx.json#L4892:9
    Old: Microsoft.Cdn/stable/2021-06-01/afdx.json#L4890:9
    1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.Cdn/stable/2021-06-01/afdx.json#L4892:9
    Old: Microsoft.Cdn/stable/2021-06-01/afdx.json#L4890:9
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'responseBasedAfdOriginErrorDetectionSettings' renamed or removed?
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'responseBasedAfdOriginErrorDetectionSettings' renamed or removed?
    New: Microsoft.Cdn/stable/2021-06-01/afdx.json#L4993:7
    Old: Microsoft.Cdn/stable/2021-06-01/afdx.json#L4990:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'identity' renamed or removed?
    New: Microsoft.Cdn/stable/2021-06-01/cdn.json#L2477:7
    Old: Microsoft.Cdn/stable/2021-06-01/cdn.json#L2477:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'identity' renamed or removed?
    New: Microsoft.Cdn/stable/2021-06-01/cdn.json#L2550:7
    Old: Microsoft.Cdn/stable/2021-06-01/cdn.json#L2607:7
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/afdx.json#L5487
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/afdx.json#L5503
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/afdx.json#L5712
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/afdx.json#L5728
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3234
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3234
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3234
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3280
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3280
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3280
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3311
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3311
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3311
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3333
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3333
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3333
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3386
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3386
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3386
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3443
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3443
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3443
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3496
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3496
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3496
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3553
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3553
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3553
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3606
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3606
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation

    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link
    Copy Markdown

    openapi-pipeline-app Bot commented Mar 11, 2022

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️❌SDK Breaking Change Tracking failed [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️ azure-sdk-for-python-track2 warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️❌ azure-sdk-for-net failed [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️ azure-sdk-for-js warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️ azure-resource-manager-schemas warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link
    Copy Markdown

    Hi @t-bzhan, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

    @JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Mar 14, 2022
    @chunyu3 chunyu3 self-requested a review March 15, 2022 01:35
    @chunyu3
    Copy link
    Copy Markdown
    Member

    chunyu3 commented Mar 16, 2022

    'azure-sdk-for-net' CI failure because of the out-of-date tests in azure-sdk-for-net and those are not caused by this PR. Service Team will update the tests later. So ignore this failure, and merge the PR.

    @chunyu3 chunyu3 merged commit 61969ee into Azure:main Mar 16, 2022
    FredericHeem pushed a commit to grucloud/azure-rest-api-specs that referenced this pull request May 16, 2022
    …Standard/Premium GA (Azure#18187)
    
    * [CDN][2021-06-01] Remove unsupported properties for Azure Front Door Standard/Premium GA
    
    * Add default value for enforceCertificateNameCheck
    
    Co-authored-by: Bo Zhang <bzhan@microsoft.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    4 participants