Skip to content

Sync eng/common directory with azure-sdk-tools for PR 11896#9147

Merged
benbp merged 1 commit intomainfrom
sync-eng/common-benbp/graph-11896
Aug 29, 2025
Merged

Sync eng/common directory with azure-sdk-tools for PR 11896#9147
benbp merged 1 commit intomainfrom
sync-eng/common-benbp/graph-11896

Conversation

@azure-sdk
Copy link
Collaborator

Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#11896 See eng/common workflow

@azure-sdk azure-sdk requested review from benbp and Copilot and removed request for benbp August 29, 2025 19:47
@azure-sdk azure-sdk requested a review from a team as a code owner August 29, 2025 19:47
@azure-sdk azure-sdk added EngSys This issue is impacting the engineering system. Central-EngSys This issue is owned by the Engineering System team. labels Aug 29, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR syncs the eng/common directory with azure-sdk-tools to handle authentication differences between corporate and TME (Test Management Environment) tenants. The changes address conditional access policy restrictions in corporate tenants that block Graph API calls.

  • Implements conditional logic to handle different tenant types when retrieving user account IDs
  • Fixes a typo in a warning message about ServicePrincipalAuth parameter
  • Adds logic to use Graph API for TME tenants while falling back to HomeAccountId for corporate tenants

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@benbp benbp merged commit 99db014 into main Aug 29, 2025
7 of 8 checks passed
@benbp benbp deleted the sync-eng/common-benbp/graph-11896 branch August 29, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants