Skip to content

Source user ID from graph api in TME#11896

Merged
benbp merged 1 commit intoAzure:mainfrom
benbp:benbp/graph
Aug 29, 2025
Merged

Source user ID from graph api in TME#11896
benbp merged 1 commit intoAzure:mainfrom
benbp:benbp/graph

Conversation

@benbp
Copy link
Member

@benbp benbp commented Aug 28, 2025

My previous PR #11531 seemed to fix the issue only partially, but RBAC assignments with the user's home account ID did not appear to be working in TME. Apparently graph api calls still work in TME and I found a cmdlet that only requires User.Read and not User.ReadAll.

CC @alzimmermsft

Copilot AI review requested due to automatic review settings August 28, 2025 20:39
@benbp benbp added the Central-EngSys This issue is owned by the Engineering System team. label Aug 28, 2025
@benbp benbp requested a review from a team as a code owner August 28, 2025 20:39
@benbp benbp self-assigned this Aug 28, 2025
@benbp benbp requested a review from weshaggard August 28, 2025 20:39
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modifies the test resource provisioning script to handle user ID retrieval differently for TME (Test Management Environment) tenants versus corporate tenants. The change addresses conditional access policy restrictions that block Graph API calls in corporate tenants while allowing them in TME tenants.

  • Updates user ID sourcing logic to use Graph API for TME tenants and fallback to context for corporate tenants
  • Fixes a typo in a warning message
  • Applies the same conditional logic in two different code sections

@benbp benbp moved this from 🤔 Triage to 🔬 Dev in PR in Azure SDK EngSys 🖥️🖱️⌨️👨‍💻🤯 Aug 28, 2025
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@benbp benbp enabled auto-merge (squash) August 29, 2025 20:16
azure-sdk added a commit to Azure/azure-sdk-for-js that referenced this pull request Aug 29, 2025
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#11896 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
azure-sdk added a commit to Azure/azure-sdk-for-rust that referenced this pull request Aug 29, 2025
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#11896 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
@benbp benbp merged commit 14522b1 into Azure:main Aug 29, 2025
11 checks passed
@benbp benbp deleted the benbp/graph branch August 29, 2025 20:23
@weshaggard weshaggard moved this from 🔬 Dev in PR to 🎊 Closed in Azure SDK EngSys 🖥️🖱️⌨️👨‍💻🤯 Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Central-EngSys This issue is owned by the Engineering System team.

Development

Successfully merging this pull request may close these issues.

5 participants