Board Review: Small API Change to App Configuration SettingSelector API

[annelo-msft]

The Basics

• Service team responsible for the client library: Azure SDK AppConfiguration Feature Team
• Link to documentation describing the service: https://docs.microsoft.com/en-us/azure/azure-app-configuration/overview
• Contact email (if service team, provide PM and Dev Lead): annelo-msft

About this client library

• Name of the client library: Azure.Data.AppConfiguration version 1.0.0-preview.5
• Languages for this review: .NET, Java, Python, JS
• Link to the service REST APIs: https://github.com/Azure/AppConfiguration#rest-api-reference

Artifacts required (per language)

We use an API review tool (apiview) to support .NET and Java API reviews. For Python and TypeScript, use the API extractor tool, then submit the output as a Draft PR to the relevant repository (azure-sdk-for-python or azure-sdk-for-js).

.NET

• Upload DLL to apiview. Link: https://apiview.azurewebsites.net/Assemblies/Review/62a221f8b9204e089862d86557637dab?diffRevisionId=5aae541729db431c83c7e0b076f831e2

• Link to samples for champion scenarios:
  @AlexanderSher

Java

• PR
• Upload JAR to apiview. Link:
  https://apiview.azurewebsites.net/Assemblies/Review/2209f75a19ca4076a31b2c7cbdbbca98?diffRevisionId=c01be5d6644140dd8489579a8f551bf7
• Link to samples for champion scenarios:
  @mssfang

Python

PR

TypeScript

• PR (has been merged into master)
• API Extractor
• Link to samples for champion scenarios
  @richardpark-msft

Champion Scenarios

n/a

Agenda for the review

Expect to handle without in-person meeting, unless an architect requests a meeting.

@AlexGhiondea, @KrzysztofCwalina

[annelo-msft]

@jimmyca15 , @zhenlan as FYI.

[KrzysztofCwalina]

The diff in the .NET API listing looks good to me.

[JonathanGiles]

I don't believe the Java listing has been updated yet. @mssfang Will you be providing the updated API so that it may be reviewed?

[mssfang]

@JonathanGiles yes. It is updated now

[richardpark-msft]

I talked with @bterlson and we're approved on the TS side. You can see his comments in the PR linked above.

[mssfang]

Added the PR for the Java side as well.

[xiangyan99]

I talked with @johanste and the change is good to Python.