[app-configuration] Renaming keys => keyFilter, label => labelFilter#6417
Merged
richardpark-msft merged 2 commits intoAzure:masterfrom Dec 6, 2019
Merged
Conversation
As part of a .net API review we discovered some inconsistent behavior with how we handle filters, especially with regards to proper escaping. This PR renames those fields and also makes them strings rather than arrays while also documenting the format allowed for the underlying string. (also, fixing an odd issue where `nock` was failing. Adding the dependency and removing a method that didn't need to be called)
annelo-msft
reviewed
Dec 5, 2019
sdk/appconfiguration/app-configuration/samples/getSettingOnlyIfChanged.ts
Show resolved
Hide resolved
annelo-msft
reviewed
Dec 5, 2019
chradek
approved these changes
Dec 5, 2019
sdk/appconfiguration/app-configuration/src/generated/src/appConfigurationContext.ts
Show resolved
Hide resolved
bterlson
approved these changes
Dec 6, 2019
Member
bterlson
left a comment
bterlson
left a comment
There was a problem hiding this comment.
Happy with the renames. Also really like the string format documentation, nice work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of a .net API review we discovered some inconsistent behavior
with how we handle filters, especially with regards to proper escaping.
This PR renames those fields and also makes them strings rather than
arrays while also documenting the format allowed for the underlying
string.
(also, fixing an odd issue where
nockwas failing. Adding thedependency and removing a method that didn't need to be called)
Fixes #6384