Ensure that packages that are both changed AND part of the AdditionalValidationPackages set are handled properly #9635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… are NOT counted as 'includedForValidation: true' if they also exist in the original 'these packages changed' set
Collaborator
|
The following pipelines have been queued for testing: |
benbp
reviewed
Jan 15, 2025
benbp
approved these changes
Jan 15, 2025
weshaggard
approved these changes
Jan 15, 2025
Co-authored-by: Ben Broderick Phillips <[email protected]>
Collaborator
|
The following pipelines have been queued for testing: |
This was referenced Jan 15, 2025
scbedd
added a commit
to Azure/azure-sdk-for-js
that referenced
this pull request
Jan 15, 2025
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#9635 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) --------- Co-authored-by: Scott Beddall <[email protected]> Co-authored-by: Scott Beddall <[email protected]> Co-authored-by: Ben Broderick Phillips <[email protected]>
swathipil
pushed a commit
to swathipil/azure-sdk-tools
that referenced
this pull request
Feb 4, 2025
…ValidationPackages set are handled properly (Azure#9635) * ensure that packages that come back from AdditionalValidationPackages are NOT counted as 'includedForValidation: true' if they also exist in the original 'these packages changed' set Co-authored-by: Ben Broderick Phillips <[email protected]> --------- Co-authored-by: Ben Broderick Phillips <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue this PR is resolving is highlighted in this pr step
Note that we're saying
However, due to the order of operations, we resolve the set of
directchanged packages first, then we walk each of them checking to see if there are additional packages that they should also include if they are changed. In the example PR above, we directly changedazure-core-opencensus, but because it was also anadditionalValidationPackageforazure-core, it was getting marked as anindirectpackage. This PR fixes our logic so that if a package is directly changed, we always count is as such, instead of accidentally overriding and claiming it is anincludedForValidationpackage.