Skip to content

Ensure that packages that are both changed AND part of the AdditionalValidationPackages set are handled properly #9635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Ensure that packages that are both changed AND part of the AdditionalValidationPackages set are handled properly #9635

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1301a98
ensure that packages that come back from AdditionalValidationPackages…
scbedd Jan 15, 2025
4b6603b
Update eng/common/scripts/Package-Properties.ps1
scbedd Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions eng/common/scripts/Package-Properties.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,12 +187,17 @@ function Get-PrPkgProperties([string]$InputDiffJson) {
}
}

$existingPackageNames = $packagesWithChanges | ForEach-Object { $_.Name }
foreach ($addition in $additionalValidationPackages) {
$key = $addition.Replace($RepoRoot, "").TrimStart('\/')

if ($lookup[$key]) {
$lookup[$key].IncludedForValidation = $true
$packagesWithChanges += $lookup[$key]
$pkg = $lookup[$key]

if ($pkg.Name -notin $existingPackageNames) {
$pkg.IncludedForValidation = $true
$packagesWithChanges += $pkg
}
}
}

Expand Down
Loading