APIView UI support for Tree Style Tokens and other Improvements #8502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
chidozieononiwu
commented
Jun 25, 2024
chidozieononiwu
commented
- This PR add UI features with general improvements and support for Tree Style API View Tokens.
- It decouples the UI from the server logic such UI only accesses the server logic through api endpoints.
chidozieononiwu
added
the
Central-EngSys
chidozieononiwu
changed the title
chidozieononiwu
force-pushed
the
feature/CodeFileFromAPISeven
branch
4 times, most recently
from
f0c84c2 to
77b54bf
Compare
maririos
reviewed
Jun 28, 2024
src/dotnet/APIView/APIViewWeb/Helpers/LanguageServiceHelpers.cs
Outdated
Show resolved
Hide resolved
src/dotnet/APIView/APIViewWeb/Repositories/CosmosAPIRevisionsRepository.cs
Show resolved
Hide resolved
chidozieononiwu
force-pushed
the
feature/CodeFileFromAPISeven
branch
from
9bea8e9 to
7c3ccef
Compare
benbp
reviewed
Jun 28, 2024
chidozieononiwu
force-pushed
the
feature/CodeFileFromAPISeven
branch
from
7c3ccef to
af7aed4
Compare
benbp
reviewed
Jun 28, 2024
Member
|
I'm working my way slowly through the code here, but the sheer size of the PR is making the github site crash for me. On a high level note, the amount of tests added do not seem like enough for the magnitude of this change. Both from a functionality/algorithm standpoint, and from a UI testing standpoint. What is the code coverage against CodeFileHelpers.cs for example? I worry that it will be very hard to make changes to this code reliably in the future for other contributors not as familiar with the architecture. Also I'm not sure I was seeing any timeouts on some of the parallel processing code. Is there a way to kill any of the |
chidozieononiwu
force-pushed
the
feature/CodeFileFromAPISeven
branch
5 times, most recently
from
6e9fcb0 to
1e5aa8d
Compare
maririos
reviewed
Jul 1, 2024
maririos
reviewed
Jul 1, 2024
Member
Author
Thank you for reviewing. 🙏🏿 |
chidozieononiwu
force-pushed
the
feature/CodeFileFromAPISeven
branch
from
1e5aa8d to
fdefd88
Compare
maririos
approved these changes
Jul 3, 2024
chidozieononiwu
force-pushed
the
feature/CodeFileFromAPISeven
branch
2 times, most recently
from
a0b7f67 to
42001d2
Compare
chidozieononiwu
force-pushed
the
feature/CodeFileFromAPISeven
branch
3 times, most recently
from
24d1f83 to
a6142fb
Compare
Good Rebase Add client SPA APIView V2 index page Sort by lastUpdated on, stop scrolling when end is reached Geting Revisions list working fine Fix dynamic height calculation for revisions table Fix APIRevisions filters Soft Delete of APIRevisions working Implement Review Creation File Upload Implemented APIView V@ Index Page Working APIViewV2 Index PAge Working Add Option in Profile for Beta UI Enable SPA deployment Update Assets Path Remove Console Logs Add Filter for Showing Reviews Aprroved for First Release Update First Release apporval indicator Update ARIRevision Filters Improvements to Requested Review Page Implement Release time Config Update First Release Approval Filters Store filters in cookies Update to TokenTree CodeFile Retrieve APITree from LeanControllers Implement CodeLines Tokens Displayed in UI Like trees Add Comments Add Comment Threads Comments Partially Implemented implement Diffing Add Logic for Diffing APITree Token Diff COmputation Work on CodeLines Compute Diff on Client Side Lazy Load Modules Move workers into services Split workers into separate files Start Implementing Lazy Loading Lazy Loading Implemented Upgrade APP to PWA Configure MIME type Pseudo Lazy Loading Pseudo Lazy Loading Show Review Page Navigation Lazy Loading CodeLines Partially working Add ShowDocumentation Button Show / Hide Documentation Fix API for Swagger Diagnostics Comment Add Review Page Options Add APIRevision Dropdowns Add Redirection to SPA UI terminate worker after 5 seconds of inactivity Capture user comments Templating for comments Add Markdown support to Comments Complete Templating for Comments Regular Diffind with lazy loaded lines Add Comparere for APITreeNode Making diff smarter Move dropdown to top left Reload Revisions smoothly Improvements to tree navigation Navigation Icons documentation buttons Documentation and Comments Show page settings Add Page Settings Show Only Diff working Show only diff working increase component budget Show Comment Setting Cache pre-flight requests for about a day Hide comments on toggle toggle Page Options Cahce http requests for content for one day Adjust Service WOrker ROute Service worker Registration Remove angular service worker Install workbox Register Workbox service worker Register Service Worker Sending from Client Side Diff working for Demo Build Code Panel Data on client side Build Code Panel Data on CLient Side Build tree on Server Build Tree On the Server Build Tree Nodes in Parallel Move Diff to Server Side Compute Diff on Server Side Show Page Navigation Fix navigation padding Working on diff style Add Diff Style Dropdown Diff Styles Partially Working Retrieve MessagePack Retrieve Message Pack Object Handle API Errors Render Space Tokens Properly Check Redirect Attempt to Improve Serialized JSON Size Eliminate empty collections from serialization Get Angular UI working Adjust Json Serialization properties Support paralleism only for multicore processors, and avoid thread starvation Jump to Navigation Add Marked As Viewd Feature Add MessagePack Serialization testing out MessagePack Add Change Histroy Switch to System.Text.Json Approval Options Ensure Diff Style is working Update Redirect to SPA and APIRevision Selection Updates to Comments Comment API Calls Set ParserStyle Modify nodeIdHashed algorithm Update Json Property Names Deserialize using gzip Update Java Icons Update Build Pipeline Add and Save Comments Add and Save Comments Left navigation toggling Toggle Left Navigation Comment Resolution Hide Line Numbers switch connected and working (#8462) * Hide Line Numbers switch connected and working * Show Line Number Switch Torubleshooting * Show Line Number Persisting but values are switched * Line Number Switch toggling correctly and changes persisting * Removed console.log Toggling of UpVotes Request Reviewers Work on Approval Buttons Page Navigation Token Navigation Support TreeStle Parser In Language Services Install dotnet Tool during App Deployment Add tool path durign deployment, enable code faile comparison for tree style codeFiles Rework comments to work across multi lines nodes Resolve PR comments Add Dependencies icon Index PAge based on User Preference adjusting Panel Sizes Propagate diff kind to node descendants ADd Back Icons Address Issues Raised in Pull Requests
chidozieononiwu
force-pushed
the
feature/CodeFileFromAPISeven
branch
from
a6142fb to
fda025b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.