Hide Line Numbers switch connected and working #8462

WhitShake · 2024-06-17T22:25:23Z

Added functionality to Line Numbers switch in right navigation panel to hide/show code line numbers in center panel.

src/dotnet/APIView/ClientSPA/angular.json

src/dotnet/APIView/ClientSPA/src/app/_components/code-panel/code-panel.component.html

src/dotnet/APIView/ClientSPA/src/app/_components/code-panel/code-panel.component.ts

...t/APIView/ClientSPA/src/app/_components/review-page-options/review-page-options.component.ts

src/dotnet/APIView/ClientSPA/src/app/_components/review-page/review-page.component.ts

Good Rebase Add client SPA APIView V2 index page Sort by lastUpdated on, stop scrolling when end is reached Geting Revisions list working fine Fix dynamic height calculation for revisions table Fix APIRevisions filters Soft Delete of APIRevisions working Implement Review Creation File Upload Implemented APIView V@ Index Page Working APIViewV2 Index PAge Working Add Option in Profile for Beta UI Enable SPA deployment Update Assets Path Remove Console Logs Add Filter for Showing Reviews Aprroved for First Release Update First Release apporval indicator Update ARIRevision Filters Improvements to Requested Review Page Implement Release time Config Update First Release Approval Filters Store filters in cookies Update to TokenTree CodeFile Retrieve APITree from LeanControllers Implement CodeLines Tokens Displayed in UI Like trees Add Comments Add Comment Threads Comments Partially Implemented implement Diffing Add Logic for Diffing APITree Token Diff COmputation Work on CodeLines Compute Diff on Client Side Lazy Load Modules Move workers into services Split workers into separate files Start Implementing Lazy Loading Lazy Loading Implemented Upgrade APP to PWA Configure MIME type Pseudo Lazy Loading Pseudo Lazy Loading Show Review Page Navigation Lazy Loading CodeLines Partially working Add ShowDocumentation Button Show / Hide Documentation Fix API for Swagger Diagnostics Comment Add Review Page Options Add APIRevision Dropdowns Add Redirection to SPA UI terminate worker after 5 seconds of inactivity Capture user comments Templating for comments Add Markdown support to Comments Complete Templating for Comments Regular Diffind with lazy loaded lines Add Comparere for APITreeNode Making diff smarter Move dropdown to top left Reload Revisions smoothly Improvements to tree navigation Navigation Icons documentation buttons Documentation and Comments Show page settings Add Page Settings Show Only Diff working Show only diff working increase component budget Show Comment Setting Cache pre-flight requests for about a day Hide comments on toggle toggle Page Options Cahce http requests for content for one day Adjust Service WOrker ROute Service worker Registration Remove angular service worker Install workbox Register Workbox service worker Register Service Worker Sending from Client Side Diff working for Demo Build Code Panel Data on client side Build Code Panel Data on CLient Side Build tree on Server Build Tree On the Server Build Tree Nodes in Parallel Move Diff to Server Side Compute Diff on Server Side Show Page Navigation Fix navigation padding Working on diff style Add Diff Style Dropdown Diff Styles Partially Working Retrieve MessagePack Retrieve Message Pack Object Handle API Errors Render Space Tokens Properly Check Redirect Attempt to Improve Serialized JSON Size Eliminate empty collections from serialization Get Angular UI working Adjust Json Serialization properties Support paralleism only for multicore processors, and avoid thread starvation Jump to Navigation Add Marked As Viewd Feature Add MessagePack Serialization testing out MessagePack Add Change Histroy Switch to System.Text.Json Approval Options Ensure Diff Style is working Update Redirect to SPA and APIRevision Selection Updates to Comments Comment API Calls Set ParserStyle Modify nodeIdHashed algorithm Update Json Property Names Deserialize using gzip Update Java Icons Update Build Pipeline Add and Save Comments Add and Save Comments Left navigation toggling Toggle Left Navigation Comment Resolution Hide Line Numbers switch connected and working (#8462) * Hide Line Numbers switch connected and working * Show Line Number Switch Torubleshooting * Show Line Number Persisting but values are switched * Line Number Switch toggling correctly and changes persisting * Removed console.log Toggling of UpVotes Request Reviewers Work on Approval Buttons Page Navigation Token Navigation

Good Rebase Add client SPA APIView V2 index page Sort by lastUpdated on, stop scrolling when end is reached Geting Revisions list working fine Fix dynamic height calculation for revisions table Fix APIRevisions filters Soft Delete of APIRevisions working Implement Review Creation File Upload Implemented APIView V@ Index Page Working APIViewV2 Index PAge Working Add Option in Profile for Beta UI Enable SPA deployment Update Assets Path Remove Console Logs Add Filter for Showing Reviews Aprroved for First Release Update First Release apporval indicator Update ARIRevision Filters Improvements to Requested Review Page Implement Release time Config Update First Release Approval Filters Store filters in cookies Update to TokenTree CodeFile Retrieve APITree from LeanControllers Implement CodeLines Tokens Displayed in UI Like trees Add Comments Add Comment Threads Comments Partially Implemented implement Diffing Add Logic for Diffing APITree Token Diff COmputation Work on CodeLines Compute Diff on Client Side Lazy Load Modules Move workers into services Split workers into separate files Start Implementing Lazy Loading Lazy Loading Implemented Upgrade APP to PWA Configure MIME type Pseudo Lazy Loading Pseudo Lazy Loading Show Review Page Navigation Lazy Loading CodeLines Partially working Add ShowDocumentation Button Show / Hide Documentation Fix API for Swagger Diagnostics Comment Add Review Page Options Add APIRevision Dropdowns Add Redirection to SPA UI terminate worker after 5 seconds of inactivity Capture user comments Templating for comments Add Markdown support to Comments Complete Templating for Comments Regular Diffind with lazy loaded lines Add Comparere for APITreeNode Making diff smarter Move dropdown to top left Reload Revisions smoothly Improvements to tree navigation Navigation Icons documentation buttons Documentation and Comments Show page settings Add Page Settings Show Only Diff working Show only diff working increase component budget Show Comment Setting Cache pre-flight requests for about a day Hide comments on toggle toggle Page Options Cahce http requests for content for one day Adjust Service WOrker ROute Service worker Registration Remove angular service worker Install workbox Register Workbox service worker Register Service Worker Sending from Client Side Diff working for Demo Build Code Panel Data on client side Build Code Panel Data on CLient Side Build tree on Server Build Tree On the Server Build Tree Nodes in Parallel Move Diff to Server Side Compute Diff on Server Side Show Page Navigation Fix navigation padding Working on diff style Add Diff Style Dropdown Diff Styles Partially Working Retrieve MessagePack Retrieve Message Pack Object Handle API Errors Render Space Tokens Properly Check Redirect Attempt to Improve Serialized JSON Size Eliminate empty collections from serialization Get Angular UI working Adjust Json Serialization properties Support paralleism only for multicore processors, and avoid thread starvation Jump to Navigation Add Marked As Viewd Feature Add MessagePack Serialization testing out MessagePack Add Change Histroy Switch to System.Text.Json Approval Options Ensure Diff Style is working Update Redirect to SPA and APIRevision Selection Updates to Comments Comment API Calls Set ParserStyle Modify nodeIdHashed algorithm Update Json Property Names Deserialize using gzip Update Java Icons Update Build Pipeline Add and Save Comments Add and Save Comments Left navigation toggling Toggle Left Navigation Comment Resolution Hide Line Numbers switch connected and working (#8462) * Hide Line Numbers switch connected and working * Show Line Number Switch Torubleshooting * Show Line Number Persisting but values are switched * Line Number Switch toggling correctly and changes persisting * Removed console.log Toggling of UpVotes Request Reviewers Work on Approval Buttons Page Navigation Token Navigation Support TreeStle Parser In Language Services Install dotnet Tool during App Deployment Add tool path durign deployment, enable code faile comparison for tree style codeFiles Rework comments to work across multi lines nodes Resolve PR comments Add Dependencies icon Index PAge based on User Preference adjusting Panel Sizes Propagate diff kind to node descendants ADd Back Icons Address Issues Raised in Pull Requests

Good Rebase Add client SPA APIView V2 index page Sort by lastUpdated on, stop scrolling when end is reached Geting Revisions list working fine Fix dynamic height calculation for revisions table Fix APIRevisions filters Soft Delete of APIRevisions working Implement Review Creation File Upload Implemented APIView V@ Index Page Working APIViewV2 Index PAge Working Add Option in Profile for Beta UI Enable SPA deployment Update Assets Path Remove Console Logs Add Filter for Showing Reviews Aprroved for First Release Update First Release apporval indicator Update ARIRevision Filters Improvements to Requested Review Page Implement Release time Config Update First Release Approval Filters Store filters in cookies Update to TokenTree CodeFile Retrieve APITree from LeanControllers Implement CodeLines Tokens Displayed in UI Like trees Add Comments Add Comment Threads Comments Partially Implemented implement Diffing Add Logic for Diffing APITree Token Diff COmputation Work on CodeLines Compute Diff on Client Side Lazy Load Modules Move workers into services Split workers into separate files Start Implementing Lazy Loading Lazy Loading Implemented Upgrade APP to PWA Configure MIME type Pseudo Lazy Loading Pseudo Lazy Loading Show Review Page Navigation Lazy Loading CodeLines Partially working Add ShowDocumentation Button Show / Hide Documentation Fix API for Swagger Diagnostics Comment Add Review Page Options Add APIRevision Dropdowns Add Redirection to SPA UI terminate worker after 5 seconds of inactivity Capture user comments Templating for comments Add Markdown support to Comments Complete Templating for Comments Regular Diffind with lazy loaded lines Add Comparere for APITreeNode Making diff smarter Move dropdown to top left Reload Revisions smoothly Improvements to tree navigation Navigation Icons documentation buttons Documentation and Comments Show page settings Add Page Settings Show Only Diff working Show only diff working increase component budget Show Comment Setting Cache pre-flight requests for about a day Hide comments on toggle toggle Page Options Cahce http requests for content for one day Adjust Service WOrker ROute Service worker Registration Remove angular service worker Install workbox Register Workbox service worker Register Service Worker Sending from Client Side Diff working for Demo Build Code Panel Data on client side Build Code Panel Data on CLient Side Build tree on Server Build Tree On the Server Build Tree Nodes in Parallel Move Diff to Server Side Compute Diff on Server Side Show Page Navigation Fix navigation padding Working on diff style Add Diff Style Dropdown Diff Styles Partially Working Retrieve MessagePack Retrieve Message Pack Object Handle API Errors Render Space Tokens Properly Check Redirect Attempt to Improve Serialized JSON Size Eliminate empty collections from serialization Get Angular UI working Adjust Json Serialization properties Support paralleism only for multicore processors, and avoid thread starvation Jump to Navigation Add Marked As Viewd Feature Add MessagePack Serialization testing out MessagePack Add Change Histroy Switch to System.Text.Json Approval Options Ensure Diff Style is working Update Redirect to SPA and APIRevision Selection Updates to Comments Comment API Calls Set ParserStyle Modify nodeIdHashed algorithm Update Json Property Names Deserialize using gzip Update Java Icons Update Build Pipeline Add and Save Comments Add and Save Comments Left navigation toggling Toggle Left Navigation Comment Resolution Hide Line Numbers switch connected and working (Azure#8462) * Hide Line Numbers switch connected and working * Show Line Number Switch Torubleshooting * Show Line Number Persisting but values are switched * Line Number Switch toggling correctly and changes persisting * Removed console.log Toggling of UpVotes Request Reviewers Work on Approval Buttons Page Navigation Token Navigation

Hide Line Numbers switch connected and working

3f4a308

WhitShake requested a review from chidozieononiwu as a code owner June 17, 2024 22:25