Where applicable, update Windows pools used to azsdk-pool-mms-win-2022-general and rename vmImage to the windows-20xx format#5493
Merged
1 commit merged intomainfrom Feb 17, 2023
Conversation
konrad-jamrozik
added
the
Central-EngSys
konrad-jamrozik
changed the title
Collaborator
|
The following pipelines have been queued for testing: |
konrad-jamrozik
changed the title
2022; rename vmImage to windows-2022
konrad-jamrozik
changed the title
2022; rename vmImage to windows-20222022; rename vmImage to windows-2022
konrad-jamrozik
changed the title
2022; rename vmImage to windows-20222022; rename related vmImages to windows-2022
This was referenced Feb 17, 2023
konrad-jamrozik
changed the title
2022; rename related vmImages to windows-2022azsdk-pool-mms-win-2022-general and rename vmImage to the windows-20xx format.
konrad-jamrozik
changed the title
azsdk-pool-mms-win-2022-general and rename vmImage to the windows-20xx format.azsdk-pool-mms-win-2022-general and rename vmImage to the windows-20xx format
mikeharder
approved these changes
Feb 17, 2023
azure-sdk
added a commit
to Azure/azure-sdk-for-js
that referenced
this pull request
Feb 17, 2023
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#5493 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) Co-authored-by: Konrad Jamrozik <kojamroz@microsoft.com>
|
Hello @azure-sdk! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Where applicable, update Windows pools used to
azsdk-pool-mms-win-2022-generaland renamevmImageto thewindows-20xxformat.This discussion explains why chose given
vmImageformat:Mike Harder: 1ES Hosted Pool image name changes
posted in Azure SDK / Engineering System 🛠️ at Wednesday, February 15, 2023 12:10 PM
For further context, please see:
WindowsandUbuntuagent pools to consume2022-Compliantimages #3407Note that:
MMS2021returned no resultsazsdk-pool-mms-win-2019returned no result except in a tool whose goal is to migrate such strings, hence nothing to do.