fix(build): cadl build error when repo url does not end with .git#5427
fix(build): cadl build error when repo url does not end with .git#54271 commit merged intoAzure:mainfrom
.git#5427Conversation
`[.git]` is a char set which means the url should ends with either `.`, or `g`, or `i`, or `t`. So if the url doesn't end with `.git` then there is no match which results in error. The fix is to remove `[.git]` char set. We don't need `(.git)*` either, because `\S+` will suppress it.
Current Behavior
After Fix
|
|
The following pipelines have been queued for testing: |
m-nash
left a comment
m-nash
left a comment
There was a problem hiding this comment.
I believe this will work.
Please verify locally both ssh and uri matching.
@weshaggard do you mind double checking this change as well?
|
Overall LGTM. nit: We have single quote and double quote format regex, shall we all use single quote? |
|
I checked in Java sdk repo, the change works now. |
|
Hello @azure-sdk! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 5 participants
[.git]is a char set which means the url should ends with either., org, ori, ort. So if the url doesn't end with.gitthen there is no match which results in error.The fix is to remove
[.git]char set. We don't need(.git)*either, because\S+will suppress it.