fix(build): cadl build error when repo url does not end with .git#34107
Closed
archerzz wants to merge 1 commit intoAzure:mainfrom
Closed
fix(build): cadl build error when repo url does not end with .git#34107archerzz wants to merge 1 commit intoAzure:mainfrom
.git#34107archerzz wants to merge 1 commit intoAzure:mainfrom
Conversation
`[.git]` is a char set which means the url should ends with either `.`, or `g`, or `i`, or `t`. So if the url doesn't end with `.git` then there is no match which results in error. The fix is to remove `[.git]` char set. We don't need `(.git)*` either, because `\S+` will suppress it.
archerzz
changed the title
.git.git
Member
Author
Current Behavior
After Fix
|
6 tasks
Member
|
I don't think you can fix it in .Net sdk repo directly. Based on my understanding, it only can be fixed in https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/scripts/Cadl-Project-Sync.ps1. Then it will be deployed to every sdk repo. |
Member
Author
Thanks @dw511214992 I didn't realize it's already in |
Member
Author
|
fix in Azure/azure-sdk-tools#5427, so close this pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[.git]is a char set which means the url should ends with either., org, ori, ort. So if the url doesn't end with.gitthen there is no match which results in error.The fix is to remove
[.git]char set. We don't need(.git)*either, because\S+will suppress it.Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.