Fix regex-based matcher to be a strict subset of GitHub-based CODEOWNERS matcher.#5330
Merged
konrad-jamrozik merged 3 commits intomainfrom Feb 8, 2023
Merged
Conversation
konrad-jamrozik
added
the
Central-EngSys
konrad-jamrozik
force-pushed
the
users/kojamroz/matcher_nostar
branch
2 times, most recently
from
c646f46 to
11b457c
Compare
weshaggard
reviewed
Feb 3, 2023
tools/code-owners-parser/CodeOwnersParser/MatchedCodeownersEntry.cs
Outdated
Show resolved
Hide resolved
konrad-jamrozik
force-pushed
the
users/kojamroz/matcher_nostar
branch
from
7e6e1f2 to
a64f734
Compare
konrad-jamrozik
changed the title
CODEOWNERS matcher when the path doesn't end with / nor *.CODEOWNERS matcher.
konrad-jamrozik
force-pushed
the
users/kojamroz/matcher_nostar
branch
from
4632a24 to
c2d4947
Compare
konrad-jamrozik
force-pushed
the
users/kojamroz/matcher_nostar
branch
from
c2d4947 to
dde6923
Compare
weshaggard
approved these changes
Feb 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As in subject. This PR is a follow-up to:
*handling in ourCODEOWNERSpath matcher #5308This PR contributes to:
Most notably, now the matcher is a strict subset of GitHub CODEOWNERS matcher. That is, for each CODEOWNERS path our matcher should behave exactly the same as GitHub CODEOWNERS path matcher, except when that path violates additional validation imposed by us (see the
MatchedCodeownersEntryclass comments for details). In such case, given CODEOWNERS path is skipped (ignored) by our matcher, never matching any path.Note that to make the matcher be a subset of the GitHub matcher, it can no longer normalize paths missing prefix
/by adding it. This change was made in this PR.