Fix suffix * handling in our CODEOWNERS path matcher#5308
Merged
konrad-jamrozik merged 3 commits intomainfrom Feb 2, 2023
Merged
Fix suffix * handling in our CODEOWNERS path matcher#5308konrad-jamrozik merged 3 commits intomainfrom
* handling in our CODEOWNERS path matcher#5308konrad-jamrozik merged 3 commits intomainfrom
Conversation
CODEOWNERS path matcher* handling in our CODEOWNERS path matcher
636a63c to
94f785a
Compare
94f785a to
c69c9ce
Compare
weshaggard
approved these changes
Feb 2, 2023
Contributor
Author
|
@weshaggard I made some significant changes since you approved; turns out, GitHub's CODEOWNERS matching logic is a bit inconsistent when it comes to handling suffixes. I did manual tests using my own scratchpad repo to confirm its behavior. The behavior is explained here. In a nutshell:
|
19fc6e0 to
3a38250
Compare
3a38250 to
446a087
Compare
weshaggard
reviewed
Feb 2, 2023
weshaggard
approved these changes
Feb 2, 2023
This was referenced Feb 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As in subject. Prompted by this comment thread:
CODEOWNERSazure-sdk-for-python#28539 (comment)There were some other issues with the matcher being inconsistent with GitHub's matcher. For details, please see this comment:
*handling in ourCODEOWNERSpath matcher #5308 (comment)This PR contributes to: