Update get-codeowners.ps1 to work with the updated RetrieveCodeOwners executable + add some tests; make assorted refactorings#5103
Conversation
|
The following pipelines have been queued for testing: |
konrad-jamrozik
added
the
Central-EngSys
|
The following pipelines have been queued for testing: |
…r all paths matching given glob path. (#5134) This PR implements for the `retrieve-codeowners` tool the ability to return not only owners for a single path, but a list of all owners for all paths resolved when matching a glob path given as input. As such, this PR contributes to: - #5135 This work is necessary to be able to compare and diff the owners of all files in repository before and after the regex matcher is turned on, per this comment: - #5088 (review) In other words, this PR contributes to unblocking to the following PR: - #5088 And as such, also contributes to: - #2770 This PR will require some upstream changes, which are captured by: - #5103 ### Additional changes - Removed logger from `CodeOwnersParser`; replaced with `Console.Out` and `Console.Error`. This addresses the following comment: - #5063 (comment) - Prevented the new regex matcher from matching paths that have `*` in them - such paths are malformed anyway (at least on Windows). - A lot of assorted changes to surrounding production & test code - please see the file diff for details. ### Implementation notes This PR leverages [`Microsoft.Extensions.FileSystemGlobbing`](https://www.nuget.org/packages/Microsoft.Extensions.FileSystemGlobbing). Doc: https://learn.microsoft.com/en-us/dotnet/core/extensions/file-globbing
konrad-jamrozik
force-pushed
the
users/kojamroz/codeowners_compare
branch
from
d4d2fed to
ac64d1d
Compare
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
konrad-jamrozik
changed the title
TargetPath to get-codeowners.ps1 + refactor & documentget-codeowners.ps1 to work with the updated RetrieveCodeOwners executable; make assorted refactororing
…le + remove obsolete tests (#5437) This is a follow-up PR to: - #5241 That PR was supposed to enable the regex-based matcher everywhere, but didn't. This PR fixes that. This PR also: - removes the obsolete `ProgramSimplePathTests` test class; it is superseded by `ProgramGlobPathTests`, which is renamed in: - #5431 - removes obsolete tests from `get-codeowners.ps1` This PR is a prerequisite for following PRs: - #5103 - #5431
konrad-jamrozik
force-pushed
the
users/kojamroz/codeowners_compare
branch
from
3a85471 to
f902ada
Compare
- capitalization fixups + some naming refactoring - update ToolVersion to 1.0.0-dev.20230213.7 - fix param: --codeowners-file-path -> --codeowners-file-path-or-url; minor fixes - update Azure.Sdk.Tools.RetrieveCodeOwners package ver to 20230213.2 - document params + add TargetPath
konrad-jamrozik
force-pushed
the
users/kojamroz/codeowners_compare
branch
from
f902ada to
866c321
Compare
|
The following pipelines have been queued for testing: |
konrad-jamrozik
changed the title
get-codeowners.ps1 to work with the updated RetrieveCodeOwners executable; make assorted refactororingget-codeowners.ps1 to work with the updated RetrieveCodeOwners executable; make assorted refactorings
|
The following pipelines have been queued for testing: |
konrad-jamrozik
changed the title
get-codeowners.ps1 to work with the updated RetrieveCodeOwners executable; make assorted refactoringsget-codeowners.ps1 to work with the updated RetrieveCodeOwners executable + add some tests; make assorted refactorings
konrad-jamrozik
force-pushed
the
users/kojamroz/codeowners_compare
branch
3 times, most recently
from
f67b238 to
2d07972
Compare
konrad-jamrozik
force-pushed
the
users/kojamroz/codeowners_compare
branch
from
2d07972 to
84d7319
Compare
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#5103 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) --------- Co-authored-by: Konrad Jamrozik <kojamroz@microsoft.com>
|
Hello @azure-sdk! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 3 participants
This PR is part of work required in preparation to merge:
Specifically, to enable review of ownership changes due to upcoming wildcards support, as explained in:
As such, this PR contributes to:
This PR is a prerequisite for following PRs:
CODEOWNERSmatcher #5431Merging prerequisite
This PR can be merged only after the following PRs are merged and relevant NuGet package published
CodeownersFile.UseRegexMatcherDefaulteverywhere where applicable + remove obsolete tests #5437retrieve-codeownerstool: change accepted params (targetPathetc.) + refactor #5104This is because this PR depends on that NuGet package.