Skip to content

Conversation

@heaths
Copy link
Member

@heaths heaths commented Apr 15, 2022

PR #3145 changed $BaseName to generate when null, but our pipelines were actually passing "Generated" such that $BaseName was never null. Our validation didn't catch this because they used resource types where it didn't matter, but a number of other live tests failed because other resource types did care (mostly about the uppercase "G").

@heaths heaths requested review from benbp and weshaggard as code owners April 15, 2022 17:09
@heaths heaths requested review from jsquire and scbedd April 15, 2022 17:09
@heaths
Copy link
Member Author

heaths commented Apr 15, 2022

I'll kick off a live test run in the Azure/azure-sdk-for-net repo for appconfiguration since it's fast.

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@heaths heaths changed the title Revert change that broke live tests Do not pass "Generated" to live tests as BaseName Apr 15, 2022
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@ghost
Copy link

ghost commented Apr 15, 2022

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit dd7b7d0 into Azure:main Apr 15, 2022
@heaths heaths deleted the revert branch April 15, 2022 20:25
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants