Support BaseName overrides in CI mode for New-TestResources.ps1#3145
Merged
1 commit merged intoAzure:mainfrom Apr 15, 2022
Merged
Support BaseName overrides in CI mode for New-TestResources.ps1#31451 commit merged intoAzure:mainfrom
1 commit merged intoAzure:mainfrom
Conversation
benbp
added
the
Central-EngSys
heaths
approved these changes
Apr 14, 2022
Collaborator
|
The following pipelines have been queued for testing: |
This was referenced Apr 14, 2022
|
Hello @azure-sdk! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
ghost
pushed a commit
that referenced
this pull request
Apr 15, 2022
PR #3145 changed `$BaseName` to generate when null, but our pipelines were actually passing "Generated" such that `$BaseName` was never null. Our validation didn't catch this because they used resource types where it didn't matter, but a number of other live tests failed because other resource types did care (mostly about the uppercase "G").
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to be able to override the randomly generated basename for stress testing, so that we can use top level values for resources and propagate them across configs (e.g. network blocking for a service bus namespace A record).