Skip to content

Read the ms.service value from csv metadata #2910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
4 commits merged into from
Mar 14, 2022
Merged

Read the ms.service value from csv metadata #2910

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1d73279
Read the ms.service value from csv metadata
sima-zhu Mar 11, 2022
f7328e0
Update eng/common/scripts/Update-DocsMsMetadata.ps1
sima-zhu Mar 14, 2022
f05a51a
Update eng/common/scripts/Update-DocsMsMetadata.ps1
sima-zhu Mar 14, 2022
91eb059
Update Update-DocsMsMetadata.ps1
sima-zhu Mar 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions eng/common/scripts/Update-DocsMsMetadata.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,13 +81,12 @@ function GetAdjustedReadmeContent($ReadmeContent, $PackageInfo, $PackageMetadata
# The $PackageMetadata could be $null if there is no associated metadata entry
# based on how the metadata CSV is filtered
$service = $PackageInfo.ServiceDirectory.ToLower()
if ($PackageMetadata -and $PackageMetadata.ServiceName) {
# Normalize service name "Key Vault" -> "keyvault"
if ($PackageMetadata -and $PackageMetadata.MSDocService) {
# Use MSDocService in csv metadata to override the service directory
# TODO: Use taxonomy for service name -- https://github.com/Azure/azure-sdk-tools/issues/1442
Copy link
Member

@weshaggard weshaggard Mar 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this TODO still interesting?

Copy link
Contributor Author

@sima-zhu sima-zhu Mar 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If they can provide useful APIs, then align with their system is the most accurate way to go and minimize human efforts

# probably from metadata
$service = $PackageMetadata.ServiceName.ToLower().Replace(" ", "")
$service = $PackageMetadata.MSDocService
}

Write-Host "The service of package: $service"
# Generate the release tag for use in link substitution
$tag = "$($PackageInfo.Name)_$($PackageInfo.Version)"
Write-Host "The tag of package: $tag"
Expand Down