Read the ms.service value from csv metadata #2910
Conversation
|
The following pipelines have been queued for testing: |
| $service = $PackageInfo.ServiceDirectory.ToLower() | ||
| if ($PackageMetadata -and $PackageMetadata.MSDocService) { | ||
| # Use MSDocService in csv metadata to override the service directory | ||
| # TODO: Use taxonomy for service name -- https://github.com/Azure/azure-sdk-tools/issues/1442 |
There was a problem hiding this comment.
Is this TODO still interesting?
There was a problem hiding this comment.
If they can provide useful APIs, then align with their system is the most accurate way to go and minimize human efforts
weshaggard
left a comment
weshaggard
left a comment
There was a problem hiding this comment.
Couple suggestions but otherwise looks good.
Co-authored-by: Wes Haggard <[email protected]>
Co-authored-by: Wes Haggard <[email protected]>
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
|
Hello @azure-sdk! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 3 participants
Our original
ms.serviceassign value as follows:ServiceNameexists, then NormalizeKey Vault - > keyvaultThe proposal:
MSDocServiceexists, then use the value directly. PM or service owner will update this to the right valueTesting pipeline on redis:
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1432407&view=results
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1432410&view=results