Updates to DevOps APi and Verify ReadMe #2396
Conversation
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
chidozieononiwu
force-pushed
the
AddArtifactFeedPackageLogic
branch
from
4b35a03 to
a0fbebb
Compare
|
The following pipelines have been queued for testing: |
|
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: |
|
The following pipelines have been queued for testing: |
| @@ -0,0 +1,17 @@ | |||
| parameters: | |||
| ScanPath: $(Build.SourcesDirectory) | |||
| $Base64EncodedAuthToken | ||
| ) | ||
|
|
||
| $uri = "https://feeds.dev.azure.com/$Organization/$Project/_apis/packaging/Feeds/$FeedId/packages?api-version=$ApiVersion&includeAllVersions=$IncludeAllVersions" |
There was a problem hiding this comment.
Did you see my other feedback in your .NET PR? If we can avoid it lets not try pulling all the package versions when we can just use the package version min and max to get the package we want.
There was a problem hiding this comment.
Or could you default to latest one if no feed version passed in?
There was a problem hiding this comment.
The challenge is to find the latest alpha version in the feed. Since sometime other versions other than alpha is listed as the latest thats why I need to retrieve all the abvailable versions.
There was a problem hiding this comment.
I can alternatively get all versions for the specific package, but I will have to call the api numerous times.
There was a problem hiding this comment.
@chidozieononiwu I'd like to better understand why my suggestion at Azure/azure-sdk-for-net#25503 (comment) doesn't work before we move forward with this new API.
There was a problem hiding this comment.
I tried it and it is very unreliable. I installes some packages and fails to install other which are clearly present in the feed. I can not say why these failures occur.
There was a problem hiding this comment.
I just posted some updates to that code in your other PR. Please give that a try.
Also I would like us to avoid taking a dependency on the devops api directly as I'd prefer we use general nuget feed apis so we could move to another nuget feed, l like nuget if we needed to.
| param ( | ||
| [string]$DocWardenVersion = "0.7.1", | ||
|
|
||
| [string]$DocWardenVersion = "0.7.2", |
There was a problem hiding this comment.
I assume we should either just default the version either here or in the yml but not both.
| $Project="public", | ||
| [Parameter(Mandatory = $true)] | ||
| $FeedId, | ||
| $ApiVersion="6.1-preview.1", |
There was a problem hiding this comment.
Why we use preview version by default?
There was a problem hiding this comment.
No particular reason. It apears to be the latest release.
| -Headers (Get-DevOpsApiHeaders -Base64EncodedToken $Base64EncodedAuthToken) ` | ||
| -MaximumRetryCount 3 | ||
|
|
||
| return $packages.value |
There was a problem hiding this comment.
I am curious what we returned here. Could you add some comments and example?
There was a problem hiding this comment.
The api returns an object like @{count, value}
chidozieononiwu
changed the title
|
Closing this infavour of #2417 |
5 participants
Uh oh!
There was an error while loading. Please reload this page.