Bug fix and improvement to aggregate reports pipeline #25503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
chidozieononiwu
commented
Nov 24, 2021
chidozieononiwu
commented
- Fixes bug in aggragate reports pipeline due to incomolet artifacts downloaded from net - core pipeline.
- Improvements to aggregate reports pipeline.
chidozieononiwu
requested review from
AlexGhiondea,
danieljurek,
maririos and
weshaggard
as code owners
chidozieononiwu
force-pushed
the
ImproveAggreagteReport
branch
2 times, most recently
from
c66ba7f to
09ba213
Compare
weshaggard
reviewed
Nov 24, 2021
chidozieononiwu
force-pushed
the
ImproveAggreagteReport
branch
6 times, most recently
from
7acc330 to
0011a7b
Compare
weshaggard
reviewed
Nov 29, 2021
weshaggard
reviewed
Nov 29, 2021
chidozieononiwu
force-pushed
the
ImproveAggreagteReport
branch
3 times, most recently
from
305032d to
bf286c0
Compare
chidozieononiwu
requested review from
AlonsoMondal,
RoyHerrod,
danielav7 and
whisper6284
as code owners
weshaggard
reviewed
Dec 2, 2021
weshaggard
reviewed
Dec 2, 2021
weshaggard
reviewed
Dec 2, 2021
chidozieononiwu
force-pushed
the
ImproveAggreagteReport
branch
from
b61f0ad to
8ef4a5c
Compare
Member
Author
|
/azp run net -core - ci |
|
No pipelines are associated with this pull request. |
Member
|
@chidozieononiwu looks like you are still doing some testing here so please ping me when you are ready for me to review. |
weshaggard
reviewed
Dec 3, 2021
chidozieononiwu
force-pushed
the
ImproveAggreagteReport
branch
from
5e291da to
44fecd9
Compare
|
This pull request is protected by Check Enforcer. |
weshaggard
reviewed
Dec 4, 2021
weshaggard
previously approved these changes
Dec 4, 2021
Member
weshaggard
left a comment
weshaggard
left a comment
There was a problem hiding this comment.
Left a couple comments but otherwise looks good. I assume the aggregate-reports pipeline is now functioning after your changes.
chidozieononiwu
force-pushed
the
ImproveAggreagteReport
branch
from
44fecd9 to
ffca93f
Compare
chidozieononiwu
force-pushed
the
ImproveAggreagteReport
branch
2 times, most recently
from
6fa0781 to
9e04a43
Compare
chidozieononiwu
force-pushed
the
ImproveAggreagteReport
branch
from
9e04a43 to
d064da4
Compare
weshaggard
reviewed
Dec 8, 2021
weshaggard
reviewed
Dec 8, 2021
weshaggard
reviewed
Dec 8, 2021
weshaggard
reviewed
Dec 8, 2021
weshaggard
dismissed
their stale review
I want to look at the other suggest before going down this route.
chidozieononiwu
force-pushed
the
ImproveAggreagteReport
branch
2 times, most recently
from
1b1b67c to
0178e0e
Compare
Member
Author
|
/check-enforcer override |
weshaggard
reviewed
Dec 9, 2021
weshaggard
approved these changes
Dec 9, 2021
Member
weshaggard
left a comment
weshaggard
left a comment
There was a problem hiding this comment.
Changes look good but lets make sure we have a green aggregate-reports pipeline before merging.
chidozieononiwu
force-pushed
the
ImproveAggreagteReport
branch
from
0178e0e to
cc73baa
Compare
Member
Author
|
/check-enforcer override |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.