Update Get-CodeOwners Logic. #2093
Conversation
chidozieononiwu
commented
Oct 12, 2021
chidozieononiwu
commented
- Consume CodeOwnersParser Logic form DevOps tools repo. (Depends on Updates to Identity Resolver #2085 + plus run of the associated pipelines).
- Seperate team alias from user alias. Incorporate changes originally started in https://github.com/Azure/azure-sdk-tools/pull/981/files
|
The following pipelines have been queued for testing: |
chidozieononiwu
force-pushed
the
UpdateCodeOwnersScript
branch
from
ed6f585 to
ce54242
Compare
|
The following pipelines have been queued for testing: |
chidozieononiwu
force-pushed
the
UpdateCodeOwnersScript
branch
3 times, most recently
from
0f26433 to
0132e82
Compare
|
The following pipelines have been queued for testing: |
chidozieononiwu
force-pushed
the
UpdateCodeOwnersScript
branch
from
0132e82 to
1b95856
Compare
|
The following pipelines have been queued for testing: |
chidozieononiwu
force-pushed
the
UpdateCodeOwnersScript
branch
from
1b95856 to
d3e20ea
Compare
|
The following pipelines have been queued for testing: |
sima-zhu
left a comment
sima-zhu
left a comment
There was a problem hiding this comment.
LGTM. Java will remove the dependency on get-pr-owners.yml after check in daily update changes.
Azure/azure-sdk-for-java#24748. We can have a followup PR to output the identity json instead of github identity only.
|
Hello @azure-sdk! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
| inputs: | ||
| command: custom | ||
| custom: 'tool' | ||
| arguments: 'install --global --add-source "${{ parameters.DevOpsFeed }}" --version "1.0.0-dev.20211018.1" "Azure.Sdk.Tools.IdentityResolver"' |
There was a problem hiding this comment.
Why are these versions different? We should pull this version into a variable and share it across both of these.
We also can consider combining these tools into one tools package.
| @@ -1,16 +1,30 @@ | |||
| parameters: | |||
| TargetVariable: '' | |||
| TargetUserVariable: 'notspecified' | |||
There was a problem hiding this comment.
These should default to empty and if they are empty then we don't write any variable.
5 participants
