Skip to content

Daily update docs for java on daily branch #24748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sima-zhu merged 18 commits into from
Oct 28, 2021
Merged

Daily update docs for java on daily branch #24748

sima-zhu merged 18 commits into from
Oct 28, 2021

Conversation

@sima-zhu
Copy link
Contributor

@sima-zhu sima-zhu commented Oct 12, 2021 •
edited
Loading

@sima-zhu sima-zhu force-pushed the daily_update branch 2 times, most recently from faef8a3 to 4e3f89e Compare October 13, 2021 22:43
@sima-zhu sima-zhu marked this pull request as ready for review October 13, 2021 22:47
weshaggard
weshaggard reviewed Oct 14, 2021
View reviewed changes
weshaggard
weshaggard reviewed Oct 14, 2021
View reviewed changes
@sima-zhu sima-zhu requested a review from weshaggard October 19, 2021 16:47
danieljurek
danieljurek reviewed Oct 20, 2021
View reviewed changes
Copy link
Member

@danieljurek danieljurek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking sharp. Do we have examples of the CI running successfully against a branch?

@sima-zhu sima-zhu requested a review from danieljurek October 20, 2021 04:24
weshaggard
weshaggard reviewed Oct 21, 2021
View reviewed changes
eng/pipelines/docindex.yml Outdated
mkdir ~/.m2/
}
@"
Copy link
Member

@weshaggard weshaggard Oct 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets move this into a file.

@sima-zhu sima-zhu requested a review from weshaggard October 21, 2021 19:40
weshaggard
weshaggard reviewed Oct 21, 2021
View reviewed changes
weshaggard
weshaggard reviewed Oct 21, 2021
View reviewed changes
weshaggard
weshaggard reviewed Oct 21, 2021
View reviewed changes
@sima-zhu sima-zhu requested a review from weshaggard October 21, 2021 20:29
weshaggard
weshaggard reviewed Oct 26, 2021
View reviewed changes
Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look reasonable to me but I'm going to defer to @danieljurek for sign-off.

danieljurek
danieljurek reviewed Oct 26, 2021
View reviewed changes
Copy link
Member

@danieljurek danieljurek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change and I think we're good.

@sima-zhu
Copy link
Contributor Author

sima-zhu commented Oct 26, 2021 •
edited
Loading

@danieljurek Here are the updates of keyvault pipeline:
The alpha version: 4.4.0-alpha.20211026.3
Service daily feed pipeline:
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1161180&view=logs&j=9d510ff3-53a8-5192-bd2d-466ce830bc13&t=6e2d5e45-d8af-5d18-88eb-1092d4db2161
DocIndex pipeline:
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1161419&view=logs&j=dc056dfc-c0cf-5958-c8c4-8da4f91a3739
Updated docs daily branch:
https://github.com/Azure/azure-docs-sdk-java/tree/daily/2021-10-26
Daily doc readme update:
image
Review site:
(To be updated)
https://review.docs.microsoft.com/en-us/java/api/overview/azure/security-keyvault-keys-readme?view=azure-java-preview&branch=daily%2F2021-10-26-ci-succeeded

image

@sima-zhu
Copy link
Contributor Author

sima-zhu commented Oct 26, 2021

/check-enforcer override

@sima-zhu sima-zhu requested a review from danieljurek October 28, 2021 04:42
danieljurek
danieljurek approved these changes Oct 28, 2021
View reviewed changes
Copy link
Member

@danieljurek danieljurek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 :shipit: 🚀 ❗ ✔️

@sima-zhu sima-zhu merged commit 1995b74 into Azure:main Oct 28, 2021
@sima-zhu sima-zhu deleted the daily_update branch October 28, 2021 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weshaggard weshaggard weshaggard left review comments

@danieljurek danieljurek danieljurek approved these changes

@hallipr hallipr Awaiting requested review from hallipr

@scbedd scbedd Awaiting requested review from scbedd

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sima-zhu @danieljurek @weshaggard