Use full package name in DevOps work item#13076
Conversation
There was a problem hiding this comment.
Pull request overview
This PR enhances package identification for Java packages by using the full package name (groupId+artifactName) in DevOps work items and related operations.
Key changes:
- Introduces
Get-FullPackageNamefunction to return full package names with proper format for different contexts - Updates
Get-PkgPropertiesto filter by both package name and GroupId when GroupId is provided - Adds GroupId parameter handling across multiple scripts for consistent Java package identification
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| eng/common/scripts/Verify-ChangeLog.ps1 | Adds GroupId parameter and passes it to Get-PkgProperties for proper package filtering |
| eng/common/scripts/Validate-All-Packages.ps1 | Uses Get-FullPackageName to ensure correct package names in DevOps work items and validation outputs |
| eng/common/scripts/Update-ChangeLog.ps1 | Adds GroupId parameter support for consistent package identification |
| eng/common/scripts/Prepare-Release.ps1 | Adds GroupId prompting for Java packages and uses full package names in API review and DevOps updates, fixes typo in prompt message |
| eng/common/scripts/Package-Properties.ps1 | Enhances Get-PkgProperties to filter by GroupId when provided for accurate package matching |
| eng/common/scripts/Helpers/Package-Helpers.ps1 | Introduces Get-FullPackageName helper function with support for different separator formats |
| eng/common/pipelines/templates/steps/verify-changelog.yml | Adds GroupId parameter to YAML template for pipeline consistency |
Comments suppressed due to low confidence (1)
eng/common/scripts/Validate-All-Packages.ps1:199
- Line 199 assigns
$pkgNameto$fullPackageNamebut this value is immediately overwritten on line 205. This line serves no purpose and should be removed to improve code clarity.
$fullPackageName = $pkgName
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
|
/azp run azure-sdk-tools - sync - eng-common |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
The following pipelines have been queued for testing: |
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#13076 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) --------- Co-authored-by: ray chen <raychen@microsoft.com>
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#13076 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) --------- Co-authored-by: ray chen <raychen@microsoft.com>
* Used full pkg name in release work items * Used full pkg name for dev ops work item * Added test * Pass in package info file path * Reverted changes to verify-changelog.yml and script * Updated script to process groupId in work items * Renamed new property to GroupId * Removed the condition check for Group * Build hash key with non-null arguments * Used the original BuildHashKey to return hash from non-null args
3 participants
Fixed #12507
Key Changes:
groupIdwhen dealing with the dev ops work itemGet-PkgPropertiesto match both of thenameandgroupIdifGroupexists