Reorder error and warning log line processing#12515
Merged
weshaggard merged 1 commit intomainfrom Oct 20, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR reorders the conditional checks in ProcessMsBuildLogLine to prioritize error detection over warning detection. This ensures that when a log line contains both : error and : warning patterns (such as NuGet's "Warning As Error" messages), it is correctly categorized and reported as an error rather than a warning.
Key Changes:
- Reordered if-elseif conditions to check for
: errorbefore: warning
Collaborator
|
The following pipelines have been queued for testing: |
This was referenced Oct 15, 2025
azure-sdk
added a commit
to Azure/azure-sdk-for-js
that referenced
this pull request
Oct 20, 2025
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#12515 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
azure-sdk
added a commit
to Azure/azure-sdk-for-rust
that referenced
this pull request
Oct 20, 2025
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#12515 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For lines that have both
: errorand: warninglets prefer the error./mnt/vss/_work/1/s/sdk/core/Azure.Core.TestFramework/src/Azure.Core.TestFramework.csproj : error NU1904: Warning As Error: Package