Skip to content

Conversation

@benbp
Copy link
Member

@benbp benbp commented Nov 19, 2020

The bypass-local-dns check fails when running in a container (and is unnecessary since we aren't using the pipelines agent image), so this adds another step to the condition to exclude it. This requires the container being set specifically with a Container variable.

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
js - template
net - template
python - template
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@weshaggard
Copy link
Member

Looks like you also cleaned up some spacing in https://github.com/Azure/azure-sdk-for-net/pull/16710/files#diff-9b2f3ee7e640936bc28109ab3de3f753734a1e7fc56c686b4bae96fc9257632fL1 so I'd suggest including that as well to avoid any inconsistencies

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
js - template
net - template
python - template
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
js - template
net - template
python - template
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@benbp
Copy link
Member Author

benbp commented Nov 30, 2020

/check-enforcer override

@benbp
Copy link
Member Author

benbp commented Nov 30, 2020

Overriding for now until @chidozieononiwu can fix the issue with a noop patch in the PR creation pipeline.

@benbp benbp merged commit 58b6f01 into Azure:master Nov 30, 2020
@benbp benbp deleted the benbp/bypass-no-container branch November 30, 2020 22:49
@weshaggard
Copy link
Member

Overriding for now until @chidozieononiwu can fix the issue with a noop patch in the PR creation pipeline.

Do we have an issue tracking that?

@benbp
Copy link
Member Author

benbp commented Dec 2, 2020

@chidozieononiwu did you already create an issue regarding the empty diff PR issue?

@chidozieononiwu
Copy link
Member

@chidozieononiwu did you already create an issue regarding the empty diff PR issue?

#1236

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants