-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Consolidate live test cloud/platform configuration, use stages, support weekly tests #16710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate live test cloud/platform configuration, use stages, support weekly tests #16710
Conversation
f3dc4c1 to
2b733d8
Compare
a5748af to
37b3d30
Compare
|
/azp run net - identity - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@benbp after thinking about this a little I think we should wait until after releases this week before we merge this change as this change has the potential to cause a number of issues for folks trying to get their tests working for release. Lets hold this change until next week. |
|
@weshaggard I agree, but we may want to work with @heaths to figure out a workaround for hsm. |
|
What in this PR was he depending on? I thought he already had a workaround based on just the script changes which were part of the eng/common change you merged earlier. |
|
Nvm you're right. |
57fe24f to
c9fb637
Compare
|
Some passing pipeline tests with this version: |
| - script: sudo ln -sf /run/systemd/resolve/resolv.conf /etc/resolv.conf | ||
| displayName: Bypass local DNS server to workaround issue resolving cognitiveservices names | ||
| condition: and(succeededOrFailed(), eq(variables['OSVmImage'], 'ubuntu-18.04')) | ||
| condition: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@benbp did you intend these eng/common changes directly into the .NET repo? We should make sure these get into the tools repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah! Missed the directory for this one. I'll make a sync PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…ort weekly tests (Azure#16710) * Consolidate live test cloud/platform configuration, use stages, support weekly tests * Update live test pipelines to use new cloud configuration * Remove psdebug statement * Use preview subscription configuration * Fix cloud config parameter reference from rebase * Shorten local dns template path
The overarching intent is to give us more control over the test matrix, and enable us to consolidate as much live test pipeline yaml as possible into azure-sdk-tools. Right now there are multiple different solutions across the language repos that could all be consolidated into one place. This will make it easier to roll out testing support for sovereign clouds, etc. across all the languages in the future. The changes here outline the proposed approach going forward for all live test pipelines.
This PR aims to achieve the above via the following:
TestCanary,weekly test, etc. When possible, we should prefer to check these values only in a single place instead of littering the template with if conditionals, to reduce complexity.I've also pulled in the changes from Azure/azure-sdk-tools#1163 in order to support the new subscription configuration schema while keeping the PR pipelines working. This should be merged soon and then I'll rebase.
The new subscription configuration schema looks like:
The cloud selection experience for manually running pipelines is also improved. Clouds are represented as stages, which can be selected for manual runs against the forthcoming weekly pipeline: