Skip to content

Prompt files for labels and codeowners tools#11802

Merged
shirelmr merged 9 commits intomainfrom
explore2025-prompts
Aug 25, 2025
Merged

Prompt files for labels and codeowners tools#11802
shirelmr merged 9 commits intomainfrom
explore2025-prompts

Conversation

@shirelmr
Copy link
Contributor

@shirelmr shirelmr commented Aug 22, 2025 •
edited
Loading

This PR enhances the SDK generation workflow by adding comprehensive validation for service labels and codeowners, ensuring proper configuration before SDK release.

New Validation Files Added:

  • Service Label Validation: Validates that service labels exist or guides users through creating new ones
  • Codeowners Validation: Ensures proper codeowner configuration with at least 2 valid owners across SDK repositories

Modified Instructions:

  • Updated SDK Generation Process: Added Step 9 for comprehensive label and codeowners validation

Copilot AI review requested due to automatic review settings August 22, 2025 17:37
@shirelmr shirelmr requested a review from a team as a code owner August 22, 2025 17:37
Copilot AI reviewed Aug 22, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the SDK generation workflow by adding comprehensive validation for service labels and codeowners to ensure proper configuration before SDK release. The changes integrate validation steps into the existing TypeSpec-to-SDK workflow.

  • Added service label validation with creation guidance for new labels
  • Added codeowners validation ensuring minimum 2 valid owners across SDK repositories
  • Integrated both validation steps into the main TypeSpec-to-SDK workflow

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
eng/common/instructions/azsdk-tools/validate-service-label.instruction.md New instruction file defining the service label validation workflow with step-by-step guidance
eng/common/instructions/azsdk-tools/validate-codeowners.instructions.md New instruction file defining the codeowners validation workflow with repository mapping and validation rules
eng/common/instructions/azsdk-tools/typespec-to-sdk.instructions.md Updated main workflow to include validation steps before release plan creation
Comments suppressed due to low confidence (2)

@azure-sdk
Copy link
Collaborator

azure-sdk commented Aug 22, 2025

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

This was referenced Aug 22, 2025
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
maririos
maririos reviewed Aug 22, 2025
View reviewed changes
@maririos maririos mentioned this pull request Aug 22, 2025
Merged
shirelmr and others added 2 commits August 22, 2025 16:08
@shirelmr @maririos
Update eng/common/instructions/azsdk-tools/typespec-to-sdk.instructio…
34be759 
…ns.md

Co-authored-by: Mariana Rios Flores <mariari@microsoft.com>
@shirelmr @maririos
Update eng/common/instructions/azsdk-tools/typespec-to-sdk.instructio…
2ee02e4 
…ns.md

Co-authored-by: Mariana Rios Flores <mariari@microsoft.com>
@azure-sdk
Copy link
Collaborator

azure-sdk commented Aug 22, 2025

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

azure-sdk commented Aug 22, 2025

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

azure-sdk commented Aug 23, 2025

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

jeo02
jeo02 reviewed Aug 25, 2025
View reviewed changes
michiisai and others added 2 commits August 25, 2025 10:22
@michiisai @jeo02
Update eng/common/instructions/azsdk-tools/validate-service-label.ins…
25e2e5c 
…truction.md

Co-authored-by: Juan Ospina <70209456+jeo02@users.noreply.github.com>
@michiisai @jeo02
Update eng/common/instructions/azsdk-tools/validate-codeowners.instru…
e2c02f7 
…ctions.md

Co-authored-by: Juan Ospina <70209456+jeo02@users.noreply.github.com>
@azure-sdk
Copy link
Collaborator

azure-sdk commented Aug 25, 2025

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@shirelmr @jeo02
Update eng/common/instructions/azsdk-tools/validate-service-label.ins…
bccb6ac 
…truction.md

Co-authored-by: Juan Ospina <70209456+jeo02@users.noreply.github.com>
@azure-sdk
Copy link
Collaborator

azure-sdk commented Aug 25, 2025

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

azure-sdk added a commit to Azure/azure-sdk-for-js that referenced this pull request Aug 25, 2025
@azure-sdk @shirelmr
@maririos @michiisai @jeo02
Sync eng/common directory with azure-sdk-tools for PR 11802 (#35674)
4152b62 
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#11802 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

---------

Co-authored-by: shirelmr <t-smarino@microsoft.com>
Co-authored-by: Shirel Marino <80732950+shirelmr@users.noreply.github.com>
Co-authored-by: Mariana Rios Flores <mariari@microsoft.com>
Co-authored-by: Michelle <t-michellema@microsoft.com>
Co-authored-by: Michelle Ma <145605943+michiisai@users.noreply.github.com>
Co-authored-by: Juan Ospina <70209456+jeo02@users.noreply.github.com>
azure-sdk added a commit to Azure/azure-sdk-for-rust that referenced this pull request Aug 25, 2025
@azure-sdk @shirelmr
@maririos @michiisai @jeo02
Sync eng/common directory with azure-sdk-tools for PR 11802 (#2940)
88d6cd7 
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#11802 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

---------

Co-authored-by: shirelmr <t-smarino@microsoft.com>
Co-authored-by: Shirel Marino <80732950+shirelmr@users.noreply.github.com>
Co-authored-by: Mariana Rios Flores <mariari@microsoft.com>
Co-authored-by: Michelle <t-michellema@microsoft.com>
Co-authored-by: Michelle Ma <145605943+michiisai@users.noreply.github.com>
Co-authored-by: Juan Ospina <70209456+jeo02@users.noreply.github.com>
@shirelmr shirelmr merged commit f36e9dc into main Aug 25, 2025
7 checks passed
@shirelmr shirelmr deleted the explore2025-prompts branch August 25, 2025 20:19
radhgupta pushed a commit to radhgupta/azure-sdk-tools that referenced this pull request Sep 9, 2025
@shirelmr @maririos
@michiisai @jeo02 @radhgupta
Prompt files for labels and codeowners tools (Azure#11802)
6b2511f 
* prompt files for labels and codeowners

* Update eng/common/instructions/azsdk-tools/typespec-to-sdk.instructions.md

Co-authored-by: Mariana Rios Flores <mariari@microsoft.com>

* Update eng/common/instructions/azsdk-tools/typespec-to-sdk.instructions.md

Co-authored-by: Mariana Rios Flores <mariari@microsoft.com>

* changed NotAServiceLabel line

* changed guidance to the documentation

* specified which PRs to display

* Update eng/common/instructions/azsdk-tools/validate-service-label.instruction.md

Co-authored-by: Juan Ospina <70209456+jeo02@users.noreply.github.com>

* Update eng/common/instructions/azsdk-tools/validate-codeowners.instructions.md

Co-authored-by: Juan Ospina <70209456+jeo02@users.noreply.github.com>

* Update eng/common/instructions/azsdk-tools/validate-service-label.instruction.md

Co-authored-by: Juan Ospina <70209456+jeo02@users.noreply.github.com>

---------

Co-authored-by: shirelmr <t-smarino@microsoft.com>
Co-authored-by: Mariana Rios Flores <mariari@microsoft.com>
Co-authored-by: Michelle <t-michellema@microsoft.com>
Co-authored-by: Michelle Ma <145605943+michiisai@users.noreply.github.com>
Co-authored-by: Juan Ospina <70209456+jeo02@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danieljurek danieljurek danieljurek left review comments

@jeo02 jeo02 jeo02 left review comments

Copilot code review Copilot Copilot left review comments

@maririos maririos maririos approved these changes

@praveenkuttappan praveenkuttappan Awaiting requested review from praveenkuttappan praveenkuttappan is a code owner

@ronniegeraghty ronniegeraghty Awaiting requested review from ronniegeraghty

+1 more reviewer

@michiisai michiisai michiisai left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@shirelmr shirelmr

@ReilleyMilne ReilleyMilne

@michiisai michiisai

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@shirelmr @azure-sdk @danieljurek @maririos @jeo02 @michiisai @ReilleyMilne