Sync eng/common directory with azure-sdk-tools for PR 11802#25138
Merged
Sync eng/common directory with azure-sdk-tools for PR 11802#25138
Conversation
azure-sdk
requested review from
Copilot and
shirelmr
and removed request for
shirelmr
azure-sdk
added
EngSys
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR syncs the eng/common directory with updates from azure-sdk-tools, specifically adding new validation instructions for service labels and codeowners in the SDK release process.
- Adds comprehensive validation workflow for service labels and codeowners
- Integrates new validation steps into the existing TypeSpec-to-SDK generation process
- Provides detailed instructions for handling various validation scenarios and creating new entries when needed
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| eng/common/instructions/azsdk-tools/validate-service-label.instruction.md | New instruction file for validating and creating service labels in the SDK release process |
| eng/common/instructions/azsdk-tools/validate-codeowners.instructions.md | New instruction file for validating codeowners entries with at least 2 valid owners |
| eng/common/instructions/azsdk-tools/typespec-to-sdk.instructions.md | Updated to integrate service label and codeowners validation as a new step in the workflow |
eng/common/instructions/azsdk-tools/validate-service-label.instruction.md
Show resolved
Hide resolved
azure-sdk
force-pushed
the
sync-eng/common-explore2025-prompts-11802
branch
5 times, most recently
from
4b9445e to
28b71ac
Compare
…ns.md Co-authored-by: Mariana Rios Flores <mariari@microsoft.com>
…ns.md Co-authored-by: Mariana Rios Flores <mariari@microsoft.com>
…truction.md Co-authored-by: Juan Ospina <70209456+jeo02@users.noreply.github.com>
…ctions.md Co-authored-by: Juan Ospina <70209456+jeo02@users.noreply.github.com>
…truction.md Co-authored-by: Juan Ospina <70209456+jeo02@users.noreply.github.com>
azure-sdk
force-pushed
the
sync-eng/common-explore2025-prompts-11802
branch
from
28b71ac to
8016ec7
Compare
danieljurek
approved these changes
Aug 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#11802 See eng/common workflow