Skip to content

Ensure that we log the actual serviceDirectories when tagging a PR build#10657

Merged
scbedd merged 3 commits intomainfrom
adjust-services
May 18, 2025
Merged

Ensure that we log the actual serviceDirectories when tagging a PR build#10657
scbedd merged 3 commits intomainfrom
adjust-services

Conversation

@scbedd
Copy link
Member

@scbedd scbedd commented May 15, 2025

for go especially the ServiceDirectory of each package doesn't necessarily align with the sdk/<X> pattern that we currently fill for ChangedServices.

Just updating this to use the generated package props Service Directories, which WILL reflect this reality.

FYI @benbp doing the needful from our convo.

@scbedd scbedd self-assigned this May 15, 2025
Copilot AI review requested due to automatic review settings May 15, 2025 02:27
@scbedd scbedd requested a review from a team as a code owner May 15, 2025 02:27
@scbedd scbedd moved this from 🤔 Triage to 🔬 Dev in PR in Azure SDK EngSys 📆🎇 May 15, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the pipeline to log the actual service directories from generated package properties, ensuring that the logged services reflect the real package properties rather than a fixed pattern.

  • Introduces a new PowerShell task ("Save package properties filtered for PR") that reads package info JSON files from the generated directory.
  • Updates the inline script to extract changed services by filtering out packages based on the IncludedForValidation property.
  • Removes the duplicate task that performed the same action previously.

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@scbedd scbedd merged commit ba8432f into main May 18, 2025
8 checks passed
@scbedd scbedd deleted the adjust-services branch May 18, 2025 20:50
@kurtzeborn kurtzeborn moved this from 🔬 Dev in PR to 🎊 Closed in Azure SDK EngSys 📆🎇 May 20, 2025
JoshLove-msft pushed a commit to JoshLove-msft/azure-sdk-tools that referenced this pull request May 29, 2025
…build (Azure#10657)

* ensure the directory that gets logged is the actual changed packages service directory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants