switch from chrono crate to time crate#965
Merged
cataggar merged 14 commits intoAzure:mainfrom Aug 2, 2022
Merged
Conversation
rylev
suggested changes
Aug 1, 2022
Contributor
rylev
left a comment
rylev
left a comment
There was a problem hiding this comment.
All and all looks good. I just have a few concerns.
Member
|
@rylev, thanks for the review! All your requested changes have been made. |
rylev
approved these changes
Aug 2, 2022
Contributor
rylev
left a comment
rylev
left a comment
There was a problem hiding this comment.
This is a pretty big change so I didn't go through every line with a fine-tooth comb, but overall, it looks like a solid change.
This was referenced Aug 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
timecrate has been well maintained and offers a better API thanchrono. Thetime::OffsetDateTimetype is similar to .NET's System.DateTimeOffset.chrome::Durationhas been replaced bystd::time::Duration. A newazure_core::datemodule contains functions for parsing and formatting formats and creating new durations.The Azure REST API Specifications use either
"format": "date-time"or"format": "date-time-rfc1123". These correspond to RFC 3339 and RFC 1123 date formats. The pull request replaces usage of RFC 2822 with RFC 1123 where the zone must beGMT.