Fix azure_security_keyvault handling of optional datetime fields#1021
Merged
rylev merged 2 commits intoAzure:mainfrom Aug 18, 2022
Merged
Fix azure_security_keyvault handling of optional datetime fields#1021rylev merged 2 commits intoAzure:mainfrom
azure_security_keyvault handling of optional datetime fields#1021rylev merged 2 commits intoAzure:mainfrom
Conversation
cataggar
commented
Aug 17, 2022
| pub enabled: bool, | ||
| #[serde(default)] | ||
| #[serde(with = "azure_core::date::timestamp::option")] | ||
| #[serde(default, with = "azure_core::date::timestamp::option")] |
Member
Author
There was a problem hiding this comment.
Some of these are fine already. It is just consistent formatting.
| struct Attributes { | ||
| enabled: Option<bool>, | ||
| #[serde(with = "azure_core::date::timestamp::option", rename = "exp")] | ||
| #[serde(default, with = "azure_core::date::timestamp::option", rename = "exp")] |
| struct Attributes { | ||
| enabled: Option<bool>, | ||
| #[serde(with = "azure_core::date::timestamp::option", rename = "exp")] | ||
| #[serde(default, with = "azure_core::date::timestamp::option", rename = "exp")] |
bmc-msft
reviewed
Aug 17, 2022
cataggar
changed the title
azure_security_keyvault handling of optional datetime fields
rylev
approved these changes
Aug 18, 2022
cataggar
added
the
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same fix as #1020, but for the SDKs. Fixed by reviewing the changes in #965. Fixes are in:
This is primarily a azure_security_keyvault fix.