Sync eng/common directory with azure-sdk-tools for PR 13009 #3369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azure-sdk
added
EngSys
Copilot finished reviewing on behalf of
azure-sdk
November 21, 2025 18:33
Contributor
There was a problem hiding this comment.
Pull request overview
This PR synchronizes the eng/common directory with azure-sdk-tools PR 13009, adding defensive handling for empty or whitespace-only entries in the PackageInfoFiles parameter.
Key Changes:
- Adds filtering to remove empty/whitespace entries from
PackageInfoFilesarrays in PowerShell scripts - Updates YAML parameter passing from JSON conversion to array syntax using
join - Enhances error messages to clarify when
PackageInfoFilescontains only empty entries
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| eng/common/scripts/Validate-All-Packages.ps1 | Adds filtering for empty strings in PackageInfoFiles parameter and updates error message |
| eng/common/scripts/Create-APIReview.ps1 | Adds filtering for empty strings in PackageInfoFiles parameter and updates error message |
| eng/common/pipelines/templates/steps/validate-all-packages.yml | Changes PackageInfoFiles parameter passing from JSON conversion to array syntax |
| eng/common/pipelines/templates/steps/create-apireview.yml | Changes PackageInfoFiles parameter passing from JSON conversion to array syntax |
raych1
approved these changes
Nov 21, 2025
azure-sdk
deleted the
sync-eng/common-users/raych1/fixed-JSON-parse-err-13009
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#13009 See eng/common workflow