[Storage] Regenerate against v0.16.0, Fix ResultHeaders in TypeSpec#2702
Merged
vincenttran-msft merged 7 commits intoAzure:mainfrom Jun 17, 2025
Merged
[Storage] Regenerate against v0.16.0, Fix ResultHeaders in TypeSpec#2702vincenttran-msft merged 7 commits intoAzure:mainfrom
v0.16.0, Fix ResultHeaders in TypeSpec#2702vincenttran-msft merged 7 commits intoAzure:mainfrom
Conversation
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR regenerates the storage blob SDK against v0.16.0 of the TypeSpec toolchain and updates breaking changes from feature/blob-tsp, including fixing ResultHeaders signatures.
- Updated client method signatures to include the new
NoFormatgeneric inResponse<T, NoFormat>. - Replaced
AccessTierwithAccessTierOptionaland updated calls/test assertions accordingly. - Bumped TypeSpec dependency versions (
tsp-location.yamlcommit hash andemitter-package.json).
Reviewed Changes
Copilot reviewed 19 out of 20 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| sdk/storage/azure_storage_blob_test/src/lib.rs | Added NoFormat import and updated create_test_blob return type |
| sdk/storage/azure_storage_blob/tsp-location.yaml | Updated commit hash for feature/blob-tsp regeneration |
| sdk/storage/azure_storage_blob/tests/blob_client.rs | Swapped AccessTier for AccessTierOptional and updated tests |
| sdk/storage/azure_storage_blob/src/lib.rs | Export AccessTierOptional instead of AccessTier |
| sdk/storage/azure_storage_blob/src/clients/block_blob_client.rs | Added NoFormat generic to commit/stage block methods |
| sdk/storage/azure_storage_blob/src/clients/blob_container_client.rs | Added NoFormat generic to container client methods |
| sdk/storage/azure_storage_blob/src/clients/blob_client.rs | Added NoFormat generic to blob client methods and updated tier param |
| eng/emitter-package.json | Bumped TypeSpec-related dependencies to 0.16.x/1.1.x series |
Files not reviewed (1)
- eng/emitter-package-lock.json: Language not supported
Comments suppressed due to low confidence (1)
sdk/storage/azure_storage_blob/src/clients/block_blob_client.rs:109
- Consider adding unit tests for
commit_block_list(andstage_block) to validate the newResponse<_, NoFormat>signature, ensuring that the client properly handles the response format change.
) -> Result<Response<BlockBlobClientCommitBlockListResult, NoFormat>> {
heaths
approved these changes
Jun 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does the following:
v0.16.0Merge before merging: [Storage] Move to
Access.internalfor Hiding Result Headers azure-rest-api-specs#35254v0.16.0changes, targeting a merge ->feature/blob-tsp