Skip to content

[EventHubs] Final docs update#8428

Merged
yunhaoling merged 3 commits intoAzure:feature/eventhubs_preview5from
yunhaoling:docupdate
Nov 5, 2019
Merged

[EventHubs] Final docs update#8428
yunhaoling merged 3 commits intoAzure:feature/eventhubs_preview5from
yunhaoling:docupdate

Conversation

@yunhaoling
Copy link
Contributor

No description provided.

@adxsdk6
Copy link

adxsdk6 commented Nov 5, 2019

Can one of the admins verify this patch?

@yunhaoling yunhaoling changed the base branch from master to feature/eventhubs_preview5 November 5, 2019 22:35
client = EventHubConsumerClient.from_connection_string(connection_str, partition_manager=partition_manager, receive_timeout=RECEIVE_TIMEOUT, retry_total=RETRY_TOTAL)
client = EventHubConsumerClient.from_connection_string(connection_str, event_hub_path=event_hub_path, partition_manager=partition_manager, receive_timeout=RECEIVE_TIMEOUT, retry_total=RETRY_TOTAL)
try:
loop.run_until_complete(client.receive(process_events, "$default"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we please update this sample in the same way as @lmazuel commented on the previous PR?
If I recall correctly, it was something like:

async def main():
    container_client = ContainerClient.from_connection_string(storage_connection_str, blob_name_str)
    partition_manager = BlobPartitionManager(container_client=container_client)
     client = EventHubConsumerClient.from_connection_string(connection_str, event_hub_path=event_hub_path, partition_manager=partition_manager, receive_timeout=RECEIVE_TIMEOUT, retry_total=RETRY_TOTAL)
    await client.receive(process_events, "$default")
    await client.close()

if __name__ == '__main__':
    loop = asyncio.get_event_loop()
    try:
        loop.run_until_complete(main())
    finally:
        loop.stop()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the sample in readme

@YijunXieMS YijunXieMS force-pushed the feature/eventhubs_preview5 branch from 5637a22 to a6340bd Compare November 5, 2019 22:46
@yunhaoling yunhaoling merged commit 9505652 into Azure:feature/eventhubs_preview5 Nov 5, 2019
yunhaoling added a commit that referenced this pull request Nov 6, 2019
* [EventHubs] Final docs update (#8428)

* Readme final update

* Update links

* update async sample in readme

* Simply samples in readme and make samples can run (#8432)

* Tiny readme fix

* Update checkpointstore README

* Update checkpointstore README

* Fix a README error
xiangyan99 added a commit that referenced this pull request Nov 8, 2019
* Updated minor version for released packages in hotfix branch

* Refactor ClientCertificateCredential construction (#8315)

* Update MSAL dependency (#8359)

* Fix InteractiveBrowserCredential caching (#8352)

* Disable depends test (#8440)

* [EventHubs] Final README update (#8430)

* [EventHubs] Final docs update (#8428)

* Readme final update

* Update links

* update async sample in readme

* Simply samples in readme and make samples can run (#8432)

* Tiny readme fix

* Update checkpointstore README

* Update checkpointstore README

* Fix a README error

* App Configuration 2019-10-01  (#8394)

* update sdk\keyvault\azure-keyvault-secrets\README.md (#8396)

* bump warden version (#8460)

* Add passing kwargs and HttpLoggingPolicy plugged (#8053)

* Live tests for managed identity, username/password, browser credentials (#7622)

* policy v2019_09_01 (#8397)

* Fix media streaming bug (#8385)

* initial commit to fix media streaming bug

- Removed media streaming related checks in synchronized_request that was causing issues with DBAs with "media" in the name
- Refactored pipeline_client.run into a _PipelineRun method for testing purposes

* bumped version

* removed references to 'Media'

* bumped version in readme

* removed unused import for pylint

* undid test config changes

* updated HISTORY with breaking changes

* modified changelog

* Work around sphinx markdown heading link bug (#8255)

* move smoke tests

update smoke-test.yml

move smoketests to common folder

* consistent smoke test requirements

* remove smoke test invocations that don't exist

* use original interface

* remove phantom smoke tests

* New CI to check autorest when changes are made in azure-core (#8509)

* ADLS Gen2 API Implementation (#8473)

* ADLS Gen2 API Implementation (#8473)

* network parameter change (#8529)

* [AutoPR] appconfiguration/resource-manager (#8528)

* New azure-mgmt-web + fixed mixin script (#8334)

* list skus test

* adding api_version in mixin instance

* regenerated new package

* regeneated tests

* history and version

* [AutoPR] cognitiveservices/data-plane/LUIS/Authoring (#7816)

* [AutoPR cognitiveservices/data-plane/LUIS/Authoring] Add v3.0 swagger (#7815)

* Generated from 7a554c128d6eba201c576885c8c2ea78f5267481

Add v3.0 swagger

* Generated from d3a4f2d1674a63bc9a4a57015f956833c7d40f7b

Update LUIS-Authoring.json

fix semantic bugs

* regenerated luis

* updated history and version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants