Fix InteractiveBrowserCredential caching#8352
Merged
chlowell merged 8 commits intorelease/dec-rollupfrom Nov 5, 2019
Merged
Conversation
chlowell
added
Client
|
Can one of the admins verify this patch? |
Member
Author
|
/azp run python - identity |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
python - identity - tests is the live test pipeline. I ran it against this branch before opening this PR. It failed as expected (because of #8314) but DevOps apparently associated that run with the commit, so this PR had failing (non-CI) tests the moment I opened it 🤷♂ Upshot: if not for this unexpected DevOps behavior, this would be a green PR. |
Member
Author
|
/azp run python - identity - tests |
|
No pipelines are associated with this pull request. |
schaabs
approved these changes
Nov 4, 2019
jianghaolu
approved these changes
Nov 4, 2019
chlowell
force-pushed
the
browser-credential-cache
branch
from
7388d0e to
fd71738
Compare
chlowell
force-pushed
the
browser-credential-cache
branch
from
fd71738 to
de7ac7e
Compare
chlowell
force-pushed
the
browser-credential-cache
branch
2 times, most recently
from
a1be35d to
9736f6b
Compare
chlowell
force-pushed
the
browser-credential-cache
branch
from
9736f6b to
18126e6
Compare
xiangyan99
added a commit
that referenced
this pull request
Nov 8, 2019
* Updated minor version for released packages in hotfix branch * Refactor ClientCertificateCredential construction (#8315) * Update MSAL dependency (#8359) * Fix InteractiveBrowserCredential caching (#8352) * Disable depends test (#8440) * [EventHubs] Final README update (#8430) * [EventHubs] Final docs update (#8428) * Readme final update * Update links * update async sample in readme * Simply samples in readme and make samples can run (#8432) * Tiny readme fix * Update checkpointstore README * Update checkpointstore README * Fix a README error * App Configuration 2019-10-01 (#8394) * update sdk\keyvault\azure-keyvault-secrets\README.md (#8396) * bump warden version (#8460) * Add passing kwargs and HttpLoggingPolicy plugged (#8053) * Live tests for managed identity, username/password, browser credentials (#7622) * policy v2019_09_01 (#8397) * Fix media streaming bug (#8385) * initial commit to fix media streaming bug - Removed media streaming related checks in synchronized_request that was causing issues with DBAs with "media" in the name - Refactored pipeline_client.run into a _PipelineRun method for testing purposes * bumped version * removed references to 'Media' * bumped version in readme * removed unused import for pylint * undid test config changes * updated HISTORY with breaking changes * modified changelog * Work around sphinx markdown heading link bug (#8255) * move smoke tests update smoke-test.yml move smoketests to common folder * consistent smoke test requirements * remove smoke test invocations that don't exist * use original interface * remove phantom smoke tests * New CI to check autorest when changes are made in azure-core (#8509) * ADLS Gen2 API Implementation (#8473) * ADLS Gen2 API Implementation (#8473) * network parameter change (#8529) * [AutoPR] appconfiguration/resource-manager (#8528) * New azure-mgmt-web + fixed mixin script (#8334) * list skus test * adding api_version in mixin instance * regenerated new package * regeneated tests * history and version * [AutoPR] cognitiveservices/data-plane/LUIS/Authoring (#7816) * [AutoPR cognitiveservices/data-plane/LUIS/Authoring] Add v3.0 swagger (#7815) * Generated from 7a554c128d6eba201c576885c8c2ea78f5267481 Add v3.0 swagger * Generated from d3a4f2d1674a63bc9a4a57015f956833c7d40f7b Update LUIS-Authoring.json fix semantic bugs * regenerated luis * updated history and version
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With these changes,
InteractiveBrowserCredentialdelegates refresh token handling to MSAL, and so should only open a browser to login once (fixes #8339). This script provides a quick validation:It should open a browser exactly once, and not raise
AssertionError.These changes also fix #8340, which was caused by calling
superonHTTPServer(an old-style class).