Skip to content

Enable live tests #6763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xiangyan99 merged 2 commits into from
Aug 13, 2019
Merged

Enable live tests #6763

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1212344
Enable live tests
xiangyan99 Aug 12, 2019
0b1ff0d
update example
xiangyan99 Aug 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...data-appconfiguration/azure/data/appconfiguration/aio/azure_configuration_client_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ class AzureAppConfigurationClient():

from azure.data.appconfiguration.aio import AzureAppConfigurationClient
connection_str = "<my connection string>"
async_client = AzureAppConfigurationClient(connection_str)
async_client = AzureAppConfigurationClient.from_connection_string(connection_str)
"""

@classmethod
Expand Down
2 changes: 1 addition & 1 deletion .../azure-data-appconfiguration/azure/data/appconfiguration/azure_appconfiguration_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ class AzureAppConfigurationClient():

from azure.data.appconfiguration import AzureAppConfigurationClient
connection_str = "<my connection string>"
client = AzureAppConfigurationClient(connection_str)
client = AzureAppConfigurationClient.from_connection_string(connection_str)
"""

@classmethod
Expand Down
27 changes: 27 additions & 0 deletions sdk/appconfiguration/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
trigger: none

jobs:
- template: ../../eng/pipelines/templates/jobs/archetype-sdk-tests.yml
parameters:
Matrix:
Linux_Python35:
OSName: 'Linux'
OSVmImage: 'ubuntu-16.04'
PythonVersion: '3.5'
MacOs_Python37:
OSName: 'MacOS'
OSVmImage: 'macOS-10.14'
PythonVersion: '3.7'
Windows_Python27:
OSName: 'Windows'
OSVmImage: 'vs2017-win2016'
PythonVersion: '2.7'
Linux_Pypy3:
OSName: 'Linux'
OSVmImage: 'ubuntu-16.04'
PythonVersion: 'pypy3'
BuildTargetingString: $(BuildTargetingString)
Copy link
Member

@scbedd scbedd Aug 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! The variable $(BuildTargetString) is configurable at the pipeline level. You can safely put just your data-plane package name at the pipeline variable level. Can walk you through that if you need!

Copy link
Member

@danieljurek danieljurek Aug 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Because this tests.yml file is specific to appconfiguration it's ok to hardcode the value you want to use here instead of configuring it manually in the pipeline.

We want to avoid pipelines that require manual configuration because it makes pipeline automation more difficult.

Copy link
Member Author

@xiangyan99 xiangyan99 Aug 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean I can just hard code "azure-data-appconfiguration"?

Copy link
Member

@scbedd scbedd Aug 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline. Set queue time variable on AzureDevOps: BuildTargetingString == "azure-data-appconfiguration"

ServiceDirectory: appconfiguration
EnvVars:
APP_CONFIG_CONNECTION: $(python-appconfiguration-connection-string)
TEST_MODE: 'RunLiveNoRecord'