Enable live tests #6763
Enable live tests #6763
Conversation
|
Can one of the admins verify this patch? |
| OSName: 'Linux' | ||
| OSVmImage: 'ubuntu-16.04' | ||
| PythonVersion: 'pypy3' | ||
| BuildTargetingString: $(BuildTargetingString) |
There was a problem hiding this comment.
This looks good! The variable $(BuildTargetString) is configurable at the pipeline level. You can safely put just your data-plane package name at the pipeline variable level. Can walk you through that if you need!
There was a problem hiding this comment.
Agreed. Because this tests.yml file is specific to appconfiguration it's ok to hardcode the value you want to use here instead of configuring it manually in the pipeline.
We want to avoid pipelines that require manual configuration because it makes pipeline automation more difficult.
There was a problem hiding this comment.
Do you mean I can just hard code "azure-data-appconfiguration"?
There was a problem hiding this comment.
Discussed offline. Set queue time variable on AzureDevOps: BuildTargetingString == "azure-data-appconfiguration"
danieljurek
left a comment
danieljurek
left a comment
There was a problem hiding this comment.
(actually submitting comments on this approval)
| OSName: 'Linux' | ||
| OSVmImage: 'ubuntu-16.04' | ||
| PythonVersion: 'pypy3' | ||
| BuildTargetingString: $(BuildTargetingString) |
There was a problem hiding this comment.
Agreed. Because this tests.yml file is specific to appconfiguration it's ok to hardcode the value you want to use here instead of configuring it manually in the pipeline.
We want to avoid pipelines that require manual configuration because it makes pipeline automation more difficult.
No description provided.