-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[azure-core] fixes sphinx paths and some docstring formatting #5699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
d1a3c17
fixes sphinx paths and some docstring formatting
kristapratico d2d118c
Merge branch 'master' into testbranch
kristapratico 2e130b7
explicitly defines keyword args
kristapratico e939ad6
Merge branch 'testbranch' of https://github.com/kristapratico/azure-s…
kristapratico File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -36,11 +36,12 @@ class AsyncRedirectPolicy(RedirectPolicy, AsyncHTTPPolicy): # type: ignore | |
| An async redirect policy in the pipeline can be configured directly or per operation. | ||
|
|
||
| Keyword arguments: | ||
|
|
||
| :param redirects_allow: Whether the client allows redirects. Defaults to True. | ||
| :param redirect_max: The maximum allowed redirects. Defaults to 30. | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same |
||
|
|
||
| Example: | ||
| .. literalinclude:: ../../../../examples/examples_async.py | ||
| .. literalinclude:: ../examples/examples_async.py | ||
| :start-after: [START async_redirect_policy] | ||
| :end-before: [END async_redirect_policy] | ||
| :language: python | ||
|
|
@@ -49,8 +50,8 @@ class AsyncRedirectPolicy(RedirectPolicy, AsyncHTTPPolicy): # type: ignore | |
| """ | ||
|
|
||
| async def send(self, request): | ||
| """Sends the PipelineRequest object to the next policy. Uses redirect settings | ||
| to send the request to redirect endpoint if necessary. | ||
| """Sends the PipelineRequest object to the next policy. | ||
| Uses redirect settings to send the request to redirect endpoint if necessary. | ||
|
|
||
| :param request: The PipelineRequest object | ||
| :type request: ~azure.core.pipeline.PipelineRequest | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -51,6 +51,7 @@ class RetryPolicy(HTTPPolicy): | |
| The retry policy in the pipeline can be configured directly, or tweaked on a per-call basis. | ||
|
|
||
| Keyword arguments: | ||
|
|
||
| :param int retry_total: Total number of retries to allow. Takes precedence over other counts. | ||
| Default value is 10. | ||
| :param int retry_connect: How many connection-related errors to retry on. | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same |
||
|
|
@@ -68,7 +69,7 @@ class RetryPolicy(HTTPPolicy): | |
| :param int retry_backoff_max: The maximum back off time. Default value is 120 seconds (2 minutes). | ||
|
|
||
| Example: | ||
| .. literalinclude:: ../../../../examples/examples_sync.py | ||
| .. literalinclude:: ../examples/examples_sync.py | ||
| :start-after: [START retry_policy] | ||
| :end-before: [END retry_policy] | ||
| :language: python | ||
|
|
@@ -252,7 +253,7 @@ def is_retry(self, settings, response): | |
|
|
||
| :param dict settings: The retry settings. | ||
| :param response: The PipelineResponse object | ||
| :type response: ~azure.core.pipeline.PipelineResponse. | ||
| :type response: ~azure.core.pipeline.PipelineResponse | ||
| :return: True if method/status code is retryable. False if not retryable. | ||
| :rtype: bool | ||
| """ | ||
|
|
@@ -325,8 +326,7 @@ def update_context(self, context, retry_settings): | |
| context['history'] = retry_settings['history'] | ||
|
|
||
| def send(self, request): | ||
| """Sends the PipelineRequest object to the next policy. | ||
| Uses retry settings if necessary. | ||
| """Sends the PipelineRequest object to the next policy. Uses retry settings if necessary. | ||
|
|
||
| :param request: The PipelineRequest object | ||
| :type request: ~azure.core.pipeline.PipelineRequest | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -45,6 +45,7 @@ class AsyncRetryPolicy(RetryPolicy, AsyncHTTPPolicy): # type: ignore | |
| The async retry policy in the pipeline can be configured directly, or tweaked on a per-call basis. | ||
|
|
||
| Keyword arguments: | ||
|
|
||
| :param int retry_total: Total number of retries to allow. Takes precedence over other counts. | ||
| Default value is 10. | ||
| :param int retry_connect: How many connection-related errors to retry on. | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. +1 |
||
|
|
@@ -62,7 +63,7 @@ class AsyncRetryPolicy(RetryPolicy, AsyncHTTPPolicy): # type: ignore | |
| :param int retry_backoff_max: The maximum back off time. Default value is 120 seconds (2 minutes). | ||
|
|
||
| Example: | ||
| .. literalinclude:: ../../../../examples/examples_async.py | ||
| .. literalinclude:: ../examples/examples_async.py | ||
| :start-after: [START async_retry_policy] | ||
| :end-before: [END async_retry_policy] | ||
| :language: python | ||
|
|
@@ -114,8 +115,7 @@ async def sleep(self, settings, transport, response=None): | |
| await self._sleep_backoff(settings, transport) | ||
|
|
||
| async def send(self, request): | ||
| """Uses the configured retry policy to send the request | ||
| to the next policy in the pipeline. | ||
| """Uses the configured retry policy to send the request to the next policy in the pipeline. | ||
|
|
||
| :param request: The PipelineRequest object | ||
| :type request: ~azure.core.pipeline.PipelineRequest | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to update as well?