Skip to content

[azure-core] fixes sphinx paths and some docstring formatting#5699

Merged
kristapratico merged 4 commits intoAzure:masterfrom
kristapratico:testbranch
Jun 5, 2019
Merged

[azure-core] fixes sphinx paths and some docstring formatting#5699
kristapratico merged 4 commits intoAzure:masterfrom
kristapratico:testbranch

Conversation

@kristapratico
Copy link
Contributor

No description provided.

@kristapratico kristapratico requested a review from xiangyan99 June 5, 2019 20:11
@kristapratico kristapratico requested a review from bryevdv as a code owner June 5, 2019 20:11
@adxsdk6
Copy link

adxsdk6 commented Jun 5, 2019

Can one of the admins verify this patch?

Keyword arguments:

:param redirects_allow: Whether the client allows redirects. Defaults to True.
:param redirect_max: The maximum allowed redirects. Defaults to 30.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update as well?

Keyword arguments:

:param redirects_allow: Whether the client allows redirects. Defaults to True.
:param redirect_max: The maximum allowed redirects. Defaults to 30.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same


:param int retry_total: Total number of retries to allow. Takes precedence over other counts.
Default value is 10.
:param int retry_connect: How many connection-related errors to retry on.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same


:param int retry_total: Total number of retries to allow. Takes precedence over other counts.
Default value is 10.
:param int retry_connect: How many connection-related errors to retry on.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Member

@xiangyan99 xiangyan99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we need to search "Keyword arguments:" to see if we miss anything.

@kristapratico kristapratico merged commit e20d485 into Azure:master Jun 5, 2019
rajivnandivada pushed a commit to rajivnandivada/azure-sdk-for-python that referenced this pull request Jul 3, 2019
…5699)

* fixes sphinx paths and some docstring formatting

* explicitly defines keyword args
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants