Skip to content

Remove AAD credentials from Service-Level-Readme-Automation.ps1 invocation #32316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danieljurek merged 1 commit into from
Oct 3, 2023
Merged

Remove AAD credentials from Service-Level-Readme-Automation.ps1 invocation #32316

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions eng/pipelines/docindex.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,11 +63,7 @@ jobs:
inputs:
pwsh: true
filePath: eng/common/scripts/Service-Level-Readme-Automation.ps1
arguments: >-
Copy link
Member

@weshaggard weshaggard Oct 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danieljurek lets also be sure to remove these variables from the docindex pipelines.

Copy link
Member Author

@danieljurek danieljurek Oct 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@weshaggard weshaggard Oct 3, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was meaning in the doc index pipelines variables https://dev.azure.com/azure-sdk/internal/_apps/hub/ms.vss-ciworkflow.build-ci-hub?_a=edit-build-definition&id=620&view=Tab_Variables

Copy link
Member Author

@danieljurek danieljurek Oct 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually done. I removed the secrets from the variable group as other secrets in there are still needed.

-DocRepoLocation $(DocRepoLocation)
-TenantId '$(opensource-aad-tenant-id)'
-ClientId '$(opensource-aad-app-id)'
-ClientSecret '$(opensource-aad-secret)'
arguments: -DocRepoLocation $(DocRepoLocation)
displayName: Generate Service Level Readme for main branch
condition: and(succeeded(), or(eq(variables['Build.Reason'], 'Schedule'), eq(variables['Force.MainUpdate'], 'true')))

Expand Down Expand Up @@ -135,11 +131,7 @@ jobs:
inputs:
pwsh: true
filePath: eng/common/scripts/Service-Level-Readme-Automation.ps1
arguments: >-
-DocRepoLocation $(DocRepoLocation)
-TenantId '$(opensource-aad-tenant-id)'
-ClientId '$(opensource-aad-app-id)'
-ClientSecret '$(opensource-aad-secret)'
arguments: -DocRepoLocation $(DocRepoLocation)
displayName: Generate Service Level Readme for Daily docs
- task: Powershell@2
inputs:
Expand Down