Remove AAD credentials from Service-Level-Readme-Automation.ps1 invocation#32316
Merged
danieljurek merged 1 commit intomainfrom Oct 3, 2023
Merged
Remove AAD credentials from Service-Level-Readme-Automation.ps1 invocation#32316danieljurek merged 1 commit intomainfrom
danieljurek merged 1 commit intomainfrom
Conversation
JimSuplizio
approved these changes
Oct 3, 2023
weshaggard
reviewed
Oct 3, 2023
| inputs: | ||
| pwsh: true | ||
| filePath: eng/common/scripts/Service-Level-Readme-Automation.ps1 | ||
| arguments: >- |
Member
There was a problem hiding this comment.
@danieljurek lets also be sure to remove these variables from the docindex pipelines.
Member
There was a problem hiding this comment.
I was meaning in the doc index pipelines variables https://dev.azure.com/azure-sdk/internal/_apps/hub/ms.vss-ciworkflow.build-ci-hub?_a=edit-build-definition&id=620&view=Tab_Variables
Member
Author
There was a problem hiding this comment.
Actually done. I removed the secrets from the variable group as other secrets in there are still needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.