[Storage] Add client-side encryption version 2.0, supporting AES-GCM-256#24798
Merged
jalauzon-msft merged 8 commits intomainfrom Jun 15, 2022
Merged
[Storage] Add client-side encryption version 2.0, supporting AES-GCM-256#24798jalauzon-msft merged 8 commits intomainfrom
jalauzon-msft merged 8 commits intomainfrom
Conversation
jalauzon-msft
requested review from
annatisch,
tasherif-msft and
vincenttran-msft
as code owners
ghost
added
the
vincenttran-msft
approved these changes
Jun 10, 2022
Member
vincenttran-msft
left a comment
vincenttran-msft
left a comment
There was a problem hiding this comment.
LGTM! Seriously great work on this! 🥳
Collaborator
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/_shared/encryption.py
Show resolved
Hide resolved
vincenttran-msft
approved these changes
Jun 15, 2022
Member
vincenttran-msft
left a comment
vincenttran-msft
left a comment
There was a problem hiding this comment.
LGTM! No glaring errors, and test coverage seems to fill in the gaps of my knowledge to determine correctness! Thanks for all your hard work on this and keeping up with these last minute changes, we really appreciate it!
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-python
that referenced
this pull request
Aug 1, 2023
Add Microsoft.StorageTasks Service | Swagger API Review (Ring 0 Service) (Azure#24798) * Add the Readme files and StorageTasks Spec file with CRUD and List by subs and rg with examples * Rectify provider namespace to Microsoft.StorageTask and refactor examples into folders * Address Lint diff failure to use the model from common-types * Update Operations API with defaut response * Add List Storage Task Assignment ARM Ids API * Add POST List Storage Task Run Report Summary API * Adding x-ms-identifiers * Spell corrections * Fix spell check errors * Add 201 response code to PUT task operation * Address minor changes and comments to reuse existing schema, update examples * Add request body to List Summary Report API, Add Example. Remove 200 status code from Delete Async * Add example reference to API file * Adding Storage task action preview API with example * Correct spelling * Addig allowed resource type constraint * Change the Reporting API to GET with Arm resource type Microsoft.StorageTasks/storageTasks/reports * Address PR comments, correct and rephrease operation ids * Change to proxy resource * Fix typo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a new version of client-side encryption (version 2.0), which utilizes AES-GCM-256, to the Blob and Queue SDK.
All changes here have been reviewed in individual PRs. This is just bringing the feature branch into
main.